Bug 663156

Summary:	repoman commit reopens commit message file instead of committing
Product:	Portage Development	Reporter:	Dirkjan Ochtman (RETIRED) <djc>
Component:	Repoman	Assignee:	Portage team <dev-portage>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	leio
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Dirkjan Ochtman (RETIRED) gentoo-dev

2018-08-08 13:21:46 UTC

This is a bit hard to describe, but I'm seeing the following behavior:

- Use `repoman commit` (my EDITOR is nano)
- Write multi-line commit message
- Save and quit (^X)

Expected behavior:

- Committing proceeds to GPG pin entry if necessary
- Then commits

Actual behavior:

- Editor restarts (different temp file name) with commit message intact and two added empty lines (after commit message, before comments)

I quit my terminal twice, in the end committed with `-M` instead.

Package-Manager: Portage-2.3.40, Repoman-2.3.9

Comment 1 Mart Raudsepp gentoo-dev

2018-08-08 13:30:38 UTC

What was the message you tried to enter there?

It does something like this if summary line is too long, or some log description body line is too long (allows a bit more than summary line does), but I think it was adding a comment about it in the new commit message it prefills (near the end, plus the buggy two new empty lines before the comments)

Comment 2 Dirkjan Ochtman (RETIRED) gentoo-dev

2018-08-08 13:32:34 UTC

Ah, yes, the summary line was too long... I guess my eyes just completely glossed over the comments so maybe this is not the best mechanism -- but at least now I know where to look.

Comment 3 Sam James archtester

2022-07-12 03:18:29 UTC

repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.