Summary: | net-nntp/nzbget systemd service enhancement | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michael Crawford (ali3nx) <mcrawford> |
Component: | Current packages | Assignee: | Sven Wegener <swegener> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, mcrawford, sbraz |
Priority: | Normal | Keywords: | EBUILD, PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
nzbget-20.0 ebuild patch
nzbget.service nzbget.conf.d.patch nzbget-20.0 ebuild patch |
Description
Michael Crawford (ali3nx)
2018-08-02 15:14:18 UTC
Created attachment 542098 [details]
nzbget.service
Created attachment 542100 [details, diff]
nzbget.conf.d.patch
Created attachment 542220 [details]
nzbget-20.0 ebuild patch
Fixed ebuild patch submission
Hi, Thanks for the unit, it's probably a really useful addition but I can't test it right now. I think that the idea behind the two config files was to let users run nzbget themselves without passing an extra config file as parameter, hence the "~" in most configuration options. If a user were to run "nzbget" without arguments, it would probably work now but it wouldn't if we were to overwrite the file. I don't have any strong arguments for or against that behaviour as I didn't introduce it. Is there any problem is you make the sytemd unit use the nzbgetd.conf file? You should use use systemd_dounit from the systemd eclass, not doins. I guess the systemd stuff is due to the eclass not supporting EAPI 7 yet, let's wait, a patch is currently being reviewed on the ML. i suspected the systemd eclass support was coming but had no idea on a timeline so the ebuild patch using doins appeared to be an eapi 7 supported approach if the eclass was not being updated and potentially abandoned. If waiting for the eclass is preferred that's great. best to do it once the right way. If you need testers i'm not sure who would qualify or how you would find volunteers. I've been using gentoo for fifteen years, was on the infra team with Daniel Robbins briefly but in that time there's many things i've never learned :) Yes, I'd rather wait for a few days/weeks. Have you tried passing --configfile /etc/nzbgetd.conf to the sytemd unit to see if it works? (In reply to Louis Sautier (sbraz) from comment #7) > Yes, I'd rather wait for a few days/weeks. Have you tried passing > --configfile /etc/nzbgetd.conf to the sytemd unit to see if it works? I'm sure it would work. harmonizing the config file used between openrc, systemd and upstream appeared to be a beneficial approach. Hi i'm curious if any progress has been made with EAPI 7 systemd.eclass? If not perhaps it may be acceptable to adjust the proposed ebuilds for EAPI 6? Nearly three months has passed since this package enhancement was submitted and perhaps some gentoo users would greatly enjoy being able to use nzbget Finding a systemd environment isn't easy for me, I'm looking into this now. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=895aef81080868046d66517df146ee6fb4cd034d commit 895aef81080868046d66517df146ee6fb4cd034d Author: Louis Sautier <sbraz@gentoo.org> AuthorDate: 2018-10-29 21:49:32 +0000 Commit: Louis Sautier <sbraz@gentoo.org> CommitDate: 2018-10-29 22:21:22 +0000 net-nntp/nzbget: bump to 21.0_pre2220, add systemd unit Closes: https://bugs.gentoo.org/662648 Signed-off-by: Louis Sautier <sbraz@gentoo.org> Package-Manager: Portage-2.3.51, Repoman-2.3.11 net-nntp/nzbget/Manifest | 1 + net-nntp/nzbget/files/nzbget.service | 18 ++++ net-nntp/nzbget/nzbget-21.0_pre2220.ebuild | 129 +++++++++++++++++++++++++++++ 3 files changed, 148 insertions(+) (In reply to Louis Sautier (sbraz) from comment #10) > Finding a systemd environment isn't easy for me, I'm looking into this now. Thank you :) |