| Summary: | app-text/goldendict-1.5.0_rc2-r2 needs patching for Qt 5.11 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Viacheslav Ostroukh <slava> |
| Component: | Current packages | Assignee: | Qt Bug Alias <qt> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jstein, nrndda, viklevin2 |
| Priority: | Normal | Keywords: | PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 653646 | ||
| Attachments: | Proposed patch | ||
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
In file included from ftshelpers.hh:12:0,
from bgl.cc:16:
fulltextsearch.hh:208:11: error: field ‘helpAction’ has incomplete type ‘QAction’
QAction helpAction;
^~~~~~~~~~
In file included from /usr/include/qt5/QtGui/qtextlayout.h:49:0,
at tinderbox image 17.0-developer_20180727-195601
That patch works, thanks! Thanks for your reports! (In reply to Viacheslav Ostroukh from comment #0) > Created attachment 540990 [details, diff] [details, diff] > I think these changes are already in the master, but not yet released. If you *think* they are already in master, please check it (otherwise there is a good opportunity to push your changes to master and get credited as author). Then if you *know* they are already in master, please take them directly from their git; we use upstream's patches if they exist. Upstream commits: 3d4a468b6c8cb154c88cf4592a5845973999dc29 a65967805ab424b299bdfa1d1f9c7ebb8a7fd517 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80fbdf3ca74c97e0b1435a178cbf5d7b60ade213 commit 80fbdf3ca74c97e0b1435a178cbf5d7b60ade213 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-08-17 21:40:45 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-08-17 22:02:02 +0000 app-text/goldendict: Fix build with Qt 5.11 Reported-by: Viacheslav Ostroukh <slava@ostroukh.me> Tested-by: Viktor Levin <viklevin2@mail.ru> Closes: https://bugs.gentoo.org/662094 Package-Manager: Portage-2.3.46, Repoman-2.3.10 .../files/goldendict-1.5.0-qt-5.11.patch | 56 ++++++++++++++++++++++ app-text/goldendict/goldendict-1.5.0_rc2-r2.ebuild | 5 +- 2 files changed, 60 insertions(+), 1 deletion(-) |
Created attachment 540990 [details, diff] Proposed patch I think these changes are already in the master, but not yet released. Some Qt includes need to be added to headers. Proposed patch attached.