Summary: | dev-python/pillow: needlessly prepends /usr/lib to library dirs | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Alexander Tsoy <alexander> |
Component: | Current packages | Assignee: | Virgil Dupras (RETIRED) <vdupras> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
pillow-5.2.0:20180722-192352.log.gz
libdirs.patch |
Description
Alexander Tsoy
2018-07-22 19:32:12 UTC
Created attachment 540526 [details, diff]
libdirs.patch
Attached patch works for me. Tested with pillow-4.3.0 and -5.2.0
I confirm the warnings. Before applying this patch, we should make sure that it doesn't affect other arches (maybe that removing "-L/usr/lib" breaks linking under x86 for example). If we remove that line, I don't see why we shouldn't remove the whole 4-lines block. If "lib" injection is spurious, "include" probably is as well. I've tried it in a x86 machine. It built fine with only the "lib" line removed, but build failed with the 4 lines block removed, as I suggested. It's probably fine to remove that line. Not worth a revbump on the 4.x line though, so I'll apply it only to 5.x. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1849bbe7d01f7bc9fb0fa115d5d63deaebb23c33 commit 1849bbe7d01f7bc9fb0fa115d5d63deaebb23c33 Author: Virgil Dupras <vdupras@gentoo.org> AuthorDate: 2018-07-27 02:58:03 +0000 Commit: Virgil Dupras <vdupras@gentoo.org> CommitDate: 2018-07-27 02:58:54 +0000 dev-python/pillow: fix link warnings Apply patch to remove spurious /usr/lib prepend to linking flags that generates linking warnings in certain situations. Reported-By: Alexander Tsoy Closes: https://bugs.gentoo.org/661830 Package-Manager: Portage-2.3.43, Repoman-2.3.10 dev-python/pillow/files/pillow-5.2.0-no-usr-lib.patch | 12 ++++++++++++ dev-python/pillow/pillow-5.2.0.ebuild | 4 ++++ 2 files changed, 16 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33875ec2cd5306aad166cb0e5202f6342c3a2f95 commit 33875ec2cd5306aad166cb0e5202f6342c3a2f95 Author: Virgil Dupras <vdupras@gentoo.org> AuthorDate: 2018-09-07 18:43:59 +0000 Commit: Virgil Dupras <vdupras@gentoo.org> CommitDate: 2018-09-07 18:45:31 +0000 dev-python/pillow: re-support pypy pypy support had been dropped in pillow 4.3 ebuild and is being re-introduced now. Tests pass. This required a little bit of library path fiddling in setup.py, the root cause of it being that `sysconfig.get_config_var('prefix')` under pypy doesn't return the same thing as with CPython. This fiddling was required if we wanted to keep the --disable-platform-guessing flag. I tried not to break the fix that was done in bug 661830. I've tried pypy3, but not all tests passed. I didn't investigate further (I'm just trying to return to pre-4.3 levels so that we can stabilize) Bug: https://bugs.gentoo.org/661830 Closes: https://bugs.gentoo.org/608620 Package-Manager: Portage-2.3.49, Repoman-2.3.10 dev-python/pillow/files/pillow-5.2.0-fix-lib-paths.patch | 16 ++++++++++++++++ dev-python/pillow/files/pillow-5.2.0-no-usr-lib.patch | 12 ------------ dev-python/pillow/pillow-5.2.0.ebuild | 4 ++-- 3 files changed, 18 insertions(+), 14 deletions(-) |