Summary: | sys-apps/kbd-2.0.4 pam flag does nothing | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Garry Filakhtov <filakhtov> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | filakhtov |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/legionus/kbd/pull/18 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Patch to fix ebuild pam flag
Patch to fix --enable-vlock/--disable-vlock |
Description
Garry Filakhtov
2018-07-20 09:43:10 UTC
Created attachment 540162 [details, diff]
Patch to fix ebuild pam flag
Use a usex helper to pass --disable-vlock when pam flag is set and pass nothing if unset.
Also, because vlock is provided separately by app-misc/vlock package, should kbd conflict when pam flag is enabled? Or, perhaps, it is good idea to drop pam flag for kbd altogether since it is currently broken and does nothing? Your patch only works around the symptoms. A patch fixing configure would be much better. Created attachment 540168 [details, diff]
Patch to fix --enable-vlock/--disable-vlock
Patch configure and configure.ac to fix --enable-vlock and --disable-vlock
@Lars Wendler good idea, thank you. Patch attached. Thanks! I've sent your patch to upstream. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c88fd4d16bd6407fe188e449b6b99549978427f commit 0c88fd4d16bd6407fe188e449b6b99549978427f Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2019-07-16 09:30:11 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2019-07-16 09:34:06 +0000 sys-apps/kbd: Bump to version 2.1.0 Closes: https://bugs.gentoo.org/661650 Package-Manager: Portage-2.3.69, Repoman-2.3.16 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> sys-apps/kbd/Manifest | 1 + sys-apps/kbd/kbd-2.1.0.ebuild | 70 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) |