| Summary: | dev-lang/clojure-1.9.0.397 version bump | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | anonymous <fakih18716> |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dschridde+gentoobugs, flow, jstein |
| Priority: | Normal | Keywords: | EBUILD, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/21285 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
clojure-1.9.0.381.ebuild
clojure-1.9.0.381.ebuild |
||
|
Description
anonymous
2018-07-17 21:25:59 UTC
https://git.archlinux.org/svntogit/community.git/tree/trunk?h=packages/clojure contains information on how to package clojure 1.9.0.381 Created attachment 539944 [details]
clojure-1.9.0.381.ebuild
I created this ebuild and tested it on my system. It works.
Please add this ebuild to gentoo overlay.
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: SRC_URI="https://download.clojure.org/install/clojure-tools-1.9.0.381.tar.gz" You can use variables here https://devmanual.gentoo.org/ebuild-writing/variables/ sed -i -e "s|PREFIX|$CLOJURE_LIB_DIR|g" clojure needs || die Created attachment 540300 [details]
clojure-1.9.0.381.ebuild
Like this?
Take dev-lang/clojure-1.10.0.403 from crocket-overlay. It works well on my system. i just came across this bug because 1.9.0 that is in tree does not compile for me. can somebody please enlighten me where the x.x.x.x versions come from? i can't see anything like this on their download page: https://clojure.org/community/downloads i can bump it to both versions mentioned, i just need clarification for this. In my crocket-overlay, you can find clojure-1.10.0.403.ebuild In https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/clojure you can find "_toolver=408" which is the last part of my clojure package's version. You can drop toolver if you like. ok, i looked at the ebuilds and there are several issues:
1) this is a binary download, not from source, it should be built from source instead
2) it installs versioned jar file and in unsupported path (should be /usr/share/clojure-${SLOT}/clojure.jar and so the path to the jar in clojure executable must be updated)
3) as ve have clojure slotted, slot number must be prepended to the executables and man pages, and the deps files, if really needed, should be put in /usr/share/clojure-{SLOT}, otherwise it will cause conflicts when more than one version is installed
could you please fix these issues?
1) Jar files are cross-platform assets. They will work on any platform that java supports. Also, it's difficult to replicate the structure of https://download.clojure.org/install/${PN}-tools-${PV}.tar.gz when I build clojure from source. I don't see a good reason to not use clojure-tools-XXX.tar.gz 2 and 3) Maybe. But, I am short of time these days. It will take several months for me to work on it again. As I understand, this builds the Clojure CLI tooling (`clj` binary), while our current ebuild only builds the language JAR (and a thin custom wrapper around `clojure.main`). Is this correct? My ebuild doesn't build anything. It just copies the contents of an archive file to appropriate places. (In reply to crocket from comment #11) > My ebuild doesn't build anything. It just copies the contents of an archive > file to appropriate places. In that case the package name should be dev-lang/clojure-bin and not dev-lang/clojure. From the ebuild it seems that a good name might also be dev-util/clojure-tools-bin, since it seems to contain the "clj" Clojure CLI tool. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cc57f9f25d40bff2e2b0e3179eac82e467f5952e commit cc57f9f25d40bff2e2b0e3179eac82e467f5952e Author: Florian Schmaus <flo@geekplace.eu> AuthorDate: 2021-06-17 15:54:16 +0000 Commit: Göktürk Yüksek <gokturk@gentoo.org> CommitDate: 2021-06-21 14:26:38 +0000 dev-lang/clojure: add 1.10.3 This is a "new kind" of clojure ebuilds, which does not longer depend on dev-java/spec-alpha and dev-java/core-specs-alpha, but instead is able to bootstrap itself. Major thanks to Göktürk Yüksek for coming up with a way to bootstrap clojure (see add-compile-spec-ant-build-target.patch). Closes: https://bugs.gentoo.org/661442 Closes: https://bugs.gentoo.org/737064 Closes: https://github.com/gentoo/gentoo/pull/21285 Signed-off-by: Florian Schmaus <flo@geekplace.eu> Signed-off-by: Göktürk Yüksek <gokturk@gentoo.org> dev-lang/clojure/Manifest | 9 ++ dev-lang/clojure/clojure-1.10.3.ebuild | 97 ++++++++++++++++++++++ .../files/add-compile-spec-ant-build-target.patch | 54 ++++++++++++ 3 files changed, 160 insertions(+) |
