Summary: | sci-libs/mpir-3.0.0: missing dependency to yasm | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Rolf Eike Beer <eike> |
Component: | Current packages | Assignee: | Gentoo Science Related Packages <sci> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dan, floppym, frp.bissey, jstein, rossbridger.cc |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/wbhart/mpir/issues/270 | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=679338 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
build.log
config.log patch to remove yasm check on non-x86 platforms |
Description
Rolf Eike Beer
2018-07-17 19:03:18 UTC
Created attachment 539908 [details]
config.log
Also affects 2.7.2. The problem is that there is an explicit dependency to yasm on x86 and amd64, but --system-yasm is passed to configure on all platforms. One could argue that upstream configure script should be able to cope with that but it certainly something we can fix on our side. yasm dependency should be conditional to cpudetection (aka --enable-fat) then? Created attachment 574536 [details, diff]
patch to remove yasm check on non-x86 platforms
I wrote a patch to fix configure.ac to remove mandatory dependency on yasm if it is not compiled on x86 platform. This seems to compile without problem on rpi3 but I'm not sure about other platforms.
It builds for me on sparc with the patch, too. However I personally dislike it: it duplicates things between the ebuild and the configure script. IMHO one should pass a flag on those platforms that expect yasm to be there and the configure script should simply ignore yasm scanning if the flag is not passed. Or something like that. But again, that's personal taste about maintainability, more important would be to get it working at all. I looked into the whole build script, the whole thing is written in a very nasty way, and there is no such options to "turn off" the usage of yasm. For platforms that don't use yasm, it simply wouldn't execute any yasm command. The mandatory dependency for external yasm has been around since the bundled one was removed from the source tree, so I reported the issue to upstream: https://github.com/wbhart/mpir/issues/270 A short term fix for Gentoo could be to pass /bin/true as yasm binary on those platforms that don't require it. (In reply to Rolf Eike Beer from comment #8) > A short term fix for Gentoo could be to pass /bin/true as yasm binary on > those platforms that don't require it. I think I would rather pass /bin/false so that the build system dies if it gets executed accidentally. Would you mind testing that? The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=298d3c36aed5cdb79508f1527944cf2e64bf8686 commit 298d3c36aed5cdb79508f1527944cf2e64bf8686 Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2019-11-11 21:48:10 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2019-11-11 21:48:42 +0000 sci-libs/mpir: pass --with-yasm=/bin/false on non-x86 archs Closes: https://bugs.gentoo.org/661430 Package-Manager: Portage-2.3.78_p18, Repoman-2.3.17_p114 Signed-off-by: Mike Gilbert <floppym@gentoo.org> sci-libs/mpir/mpir-3.0.0.ebuild | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) |