| Summary: | gnome-extra/gtkhtml-4.10.0 fails to build with enchant-2.1.2 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Helmut Jarausch <jarausch> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ostroffjh |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 629838 | ||
| Attachments: |
build log
patch to allow gtkhtml-4.10.0 to use enchant > 2.0 patch to allow gtkhtml-4.10.0 to use enchant > 2.1 |
||
Created attachment 539068 [details, diff]
patch to allow gtkhtml-4.10.0 to use enchant > 2.0
Using this patch, I have gtkhtml-4.10.0 using enchant-2.1.1
That patch will work for enchant up to 2.1.2. Enchant 2.2 changed the pkg-config name from enchant to enchant-2, so a further patch for configure (or configure.ac) will be needed. I'll submit if I can manage it, but it might be similar to the one for gtkspell (https://bugs.gentoo.org/629772) Created attachment 563244 [details, diff]
patch to allow gtkhtml-4.10.0 to use enchant > 2.1
I have used this patch to compile against enchant 2.2.3. I "THINK" it will work for 2.1.x, but have not tested. (2.1.x is still enchant, but 2.2.x has changed to enchant-2.) For this to work, you need to add "eautoreconf" at the end of src_prepare, and also need to add autotools to the ingerit line in the ebuild.
Looks like the same kind of patch was already included in gtkhtml-4.10.0-r1: commit 6db1cfeb695624be1aea007bc691c7252f74a95b Author: Dennis Lamm <expeditioneer@gentoo.org> Date: Tue Jan 29 21:16:16 2019 +0100 gnome-extra/gtkhtml: added revision with enchant-2 compatibility However I'm now revbumping it to -r2, to depend on parallel-installable enchant:2 instead, and fix some ebuild issues in the -r1 revbump (and pushing that into ~arch now). The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=510124e09d078b6fbdc4a92b8026fad768b357af commit 510124e09d078b6fbdc4a92b8026fad768b357af Author: Mart Raudsepp <leio@gentoo.org> AuthorDate: 2020-02-02 20:02:57 +0000 Commit: Mart Raudsepp <leio@gentoo.org> CommitDate: 2020-02-02 20:05:28 +0000 gnome-extra/gtkhtml: use app-text/enchant:2 and ebuild fixups The patching was done bad, calling default instead of gnome2_src_prepare; use GNOME2_EAUTORECONF="yes" instead to work in correct order as well. Also remove the now unnecessary -r1 p.mask (-r2 is not masked on purpose, as it's now ready to enter ~arch as enchant:2 is not p.masked) Closes: https://bugs.gentoo.org/660720 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Mart Raudsepp <leio@gentoo.org> .../{gtkhtml-4.10.0-r1.ebuild => gtkhtml-4.10.0-r2.ebuild} | 12 ++++-------- profiles/package.mask | 4 ---- 2 files changed, 4 insertions(+), 12 deletions(-) *** Bug 676922 has been marked as a duplicate of this bug. *** |
Created attachment 538822 [details] build log gtkhtml-spell-checker.c: In function 'gtkhtml_spell_checker_add_word': gtkhtml-spell-checker.c:378:2: error: implicit declaration of function 'enchant_dict_add_to_pwl'; did you mean 'enchant_dict_add_to_session'? [-Werror=implicit-function-declaration] enchant_dict_add_to_pwl (dict, word, length);