Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 660582

Summary: sci-libs/vtk-8.2.0: [QA] One or more CMake variables were not used by the project
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Bernd <waebbl-gentoo>
Status: RESOLVED FIXED    
Severity: QA CC: proxy-maint, sam, sci
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/21110
https://github.com/gentoo/gentoo/pull/24081
Whiteboard:
Package list:
Runtime testing required: ---

Description Toralf Förster gentoo-dev 2018-07-07 07:23:50 UTC
QA: other
One or more CMake variables were not used by the project:
  BUILD_VTK_BUILD_ALL_MODULES_FOR_TESTS
  DESIRED_QT_VERSION
  Module_vtkFiltersStatisticsGnuR
  QT_INCLUDE_DIR
  QT_WRAP_CPP
  QT_WRAP_UI
  USE_DOCUMENTATION_HTML_HELP
  USE_VTK_USE_BOOST
  VTK_DATA_ROOT
  VTK_DIR
  VTK_USE_BOOST
  VTK_USE_GL2PS
  VTK_USE_ODBC
  VTK_USE_PARALLEL
  VTK_USE_QVTK
  VTK_USE_QVTK_OPENGL
  VTK_USE_QVTK_QTOPENGL
  VTK_USE_SYSTEM_AUTOBAHN
  VTK_USE_SYSTEM_DIY2
  VTK_USE_SYSTEM_FreeType
  VTK_USE_SYSTEM_GL2PS
  VTK_USE_SYSTEM_LIBPROJ4
  VTK_USE_SYSTEM_LibXml2
  VTK_USE_SYSTEM_TWISTED
  VTK_USE_SYSTEM_XDMF2
  VTK_USE_SYSTEM_XDMF3
  VTK_USE_SYSTEM_ZOPE
  VTK_WRAP_PYTHON_SIP

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.0-desktop-gnome_20180623-162007

  -------------------------------------------------------------------
Comment 1 Andreas Sturmlechner gentoo-dev 2020-06-06 09:21:39 UTC
Still unaddressed by 8.2.0:

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_VTK_BUILD_ALL_MODULES_FOR_TESTS
    CMAKE_DISABLE_FIND_PACKAGE_Qt5WebKitWidgets
    DESIRED_QT_VERSION
    Module_vtkFiltersStatisticsGnuR
    QT_INCLUDE_DIR
    QT_WRAP_CPP
    QT_WRAP_UI
    USE_DOCUMENTATION_HTML_HELP
    USE_VTK_USE_BOOST
    VTK_DATA_ROOT
    VTK_DIR
    VTK_USE_BOOST
    VTK_USE_GL2PS
    VTK_USE_ODBC
    VTK_USE_PARALLEL
    VTK_USE_QVTK
    VTK_USE_QVTK_OPENGL
    VTK_USE_QVTK_QTOPENGL
    VTK_USE_SYSTEM_AUTOBAHN
    VTK_USE_SYSTEM_DIY2
    VTK_USE_SYSTEM_FreeType
    VTK_USE_SYSTEM_LibXml2
    VTK_USE_SYSTEM_OGGTHEORA
    VTK_USE_SYSTEM_TWISTED
    VTK_USE_SYSTEM_XDMF2
    VTK_USE_SYSTEM_XDMF3
    VTK_USE_SYSTEM_ZOPE
    VTK_WRAP_PYTHON_SIP
    VTK_WRAP_TCL
Comment 2 Larry the Git Cow gentoo-dev 2021-06-10 03:38:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2728a6a5f2c0a39f44ceee464a764bec6da2c320

commit 2728a6a5f2c0a39f44ceee464a764bec6da2c320
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2021-06-03 16:52:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-10 03:37:44 +0000

    sci-libs/vtk: improve all-modules USE flag
    
    - add missing flags to REQUIRED_USE
    - add new mysql USE flag - needed by all-modules, adds new dependency on
            dev-db/mysql-connector-c. Dev-db/mariadb-connector-c isn't supported
            by this version. Fix an issue with using of deprecated my_bool when
            using mysql-connector-c.
    - remove xdmf2 USE flag, block sci-libs/xdmf2 with all-modules:
            sci-libs/xdmf2 doesn't ship any cmake configuration files, which leads
            to configuration errors when trying to build against external xdmf2
    - block sci-libs/xdmf2: when built against internal xdmf2, there are header
            file collisions with the header files installed by sci-libs/xdmf2
    - add dependency on sci-libs/kissfft, bug #754684) and drop bundled
    - fix an issue with xdmf3 library being installed in both library locations,
            lib and lib64
    - fix QA issues with RPATH
    - byte compile python files
    - disable searching for zfp (no package in tree)
    - addresses some QA issues with defined but unused cmake variables: fixing all
            of them would need a thorough testing of each single USE flag and checking
            where these belong to, in this over-complex build system (bug #660582)
    
    Closes: https://bugs.gentoo.org/793839
    Closes: https://bugs.gentoo.org/754684
    Closes: https://bugs.gentoo.org/646846
    Bug: https://bugs.gentoo.org/660582
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Signed-off-by: Sam James <sam@gentoo.org>

 ...01-fix-library-installation-dir-for-xdmf3.patch |  57 +++
 sci-libs/vtk/vtk-8.2.0-r2.ebuild                   | 382 +++++++++++++++++++++
 2 files changed, 439 insertions(+)
Comment 3 Bernd 2021-06-10 04:41:37 UTC
The PR in comment #2 solves the issue only for the all-modules and dependent USE flags. There will probably still some QA warnings left, which I'm going to fix later.
Comment 4 Larry the Git Cow gentoo-dev 2022-02-21 23:24:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=456dff1993bc8dd2dabd3a7642ffcb8229b30407

commit 456dff1993bc8dd2dabd3a7642ffcb8229b30407
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2022-02-04 19:15:16 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-21 23:23:52 +0000

    sci-libs/vtk: let v9 build against ffmpeg-5
    
    Backports an upstream patch to successfully build against
    media-video/ffmpeg-5.
    
    Closes: https://bugs.gentoo.org/831595
    Closes: https://bugs.gentoo.org/727338
    Closes: https://bugs.gentoo.org/660582
    
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/24081
    Signed-off-by: Sam James <sam@gentoo.org>

 ...-IO-FFMPEG-support-FFmpeg-5.0-API-changes.patch | 141 +++++++++++++++++++++
 sci-libs/vtk/vtk-9.0.3-r4.ebuild                   |   1 +
 sci-libs/vtk/vtk-9.1.0.ebuild                      |   3 +-
 3 files changed, 144 insertions(+), 1 deletion(-)