Bug 660508 – app-portage/portage-utils does not respect BINPKG_COMPRESS

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Joakim Tjernlund 2018-07-06 12:40:49 UTC]

BINPKG_COMPRESS controls how a bin pkg is compressed.
qmerge (more apps too?) just assumes it is bzip2 and will
fail if it isn't.

qmerge could support whatever busybox tar support:

BINPKG_COMPRESS="" # no compression
BINPKG_COMPRESS="gzip" 
BINPKG_COMPRESS="bzip2"
BINPKG_COMPRESS="xz"

[Comment 1 Joakim Tjernlund 2018-07-20 00:10:40 UTC]

Any thougts?

[Comment 2 Fabian Groffen 2018-07-20 05:49:28 UTC]

If that var is stored in the xpak metadata, then we can access it.  I hope it is, in other words.  Or does the filename change?

[Comment 3 Joakim Tjernlund 2018-07-20 21:45:39 UTC]

I do not know if there is a variable stored somewhere but you can look at
magic bytes to identify compression method. Much like gnu tar does,
you do not have tell gnu tar how it is compressed. Pity busybox cannot do that(yet anyway).
The filename does NOT change.

[Comment 4 Fabian Groffen 2018-07-22 14:49:26 UTC]

Would you perhaps have an example binpkg for me?

[Comment 5 Joakim Tjernlund 2018-07-22 18:27:14 UTC]

(In reply to Fabian Groffen from comment #4)
> Would you perhaps have an example binpkg for me?

Well, not ATM. I am travelling for about 10 days more and no access.
Should be easy to create thoug:
BINPKG_COMPRESS="" ebuild path/to/ebuild package

[Comment 6 Larry the Git Cow 2018-08-01 13:28:47 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=e04d4940401a13f6851c732b70bdba0a64902d10

commit e04d4940401a13f6851c732b70bdba0a64902d10
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2018-08-01 13:26:32 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2018-08-01 13:26:32 +0000

    qmerge: implement laymans file identification, bug #660508
    
    Portage can create binpkgs compressed differently than with bzip2, so
    try to probe the file quickly before untarring, so we can use the
    correct flag with tar.
    
    Bug: https://bugs.gentoo.org/660508

 qmerge.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 46 insertions(+), 2 deletions(-)

[Comment 7 Larry the Git Cow 2018-08-01 13:54:04 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86b8e521983302545dea5c39c5a325d08c635837

commit 86b8e521983302545dea5c39c5a325d08c635837
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2018-08-01 13:53:47 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2018-08-01 13:53:47 +0000

    app-portage/portage-utils: version bump to v0.73
    
    Closes: https://bugs.gentoo.org/661762
    Closes: https://bugs.gentoo.org/661474
    Closes: https://bugs.gentoo.org/660508
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 app-portage/portage-utils/Manifest                                      | 2 +-
 .../{portage-utils-0.71.ebuild => portage-utils-0.73.ebuild}            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

[Comment 8 Joakim Tjernlund 2018-08-01 21:06:20 UTC]

Thanks!

Gotta test this out when I return to work :)