Summary: | xdg.eclass: incorrect use of DEPEND | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
Component: | Eclasses | Assignee: | Freedesktop bugs <freedesktop-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arfrever.fta, flow, qa, sam |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 660306 | ||
Bug Blocks: |
Description
Michał Górny
2018-07-03 21:52:28 UTC
I think we discussed this on IRC already, just writing down the arguments again for historical purpose. These dependencies are DEPEND in the context of the eclass as at some point in time, most packages that used them, needed them during build, either as a configure check or run at install-local target. Also these packages are not required once they have done their cache update job so having it in DEPEND allowed for their removal after build. I understand this isn't correct wrt PMS but this will take time to inspect all packages using it to set it right. *** Bug 685916 has been marked as a duplicate of this bug. *** They should be BDEPEND+RDEPEND then. Fixed by: commit 8f7593ab923d047fe43ee96a4d59613354b1ef01 Author: Florian Schmaus <flow@gentoo.org> Date: Thu Jul 15 13:14:23 2021 +0200 xdg.eclass: add EAPI 8 support Note that this removes the export of src_prepare in EPAI 8 as requested by ionen: 1. remove src_prepare export in EAPI-8 While "some" packages need xdg_environment_reset, most don't because the eclass is often only inherited to handle icons/.desktop and this just needlessly overwrite the src_prepare of other eclasses requiring more careful inherit ordering (e.g. inherit xdg cmake). I'd prefer it was clear when a package need this by calling xdg_environment_reset directly. Unless there is a non-trivial amount of packages that need it (e.g. for tests) that I'm not aware of. Thanks to ulm and others for providing feedback. Signed-off-by: Florian Schmaus <flow@gentoo.org> |