Summary: | media-video/pitivi-0.98.1 (with pycairo-1.17.0) - static declaration of ‘Pycairo_CAPI’ follows non-static declaration static Pycairo_CAPI_t *Pycairo_CAPI | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Juergen Rose <rose> |
Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gentoo, gstreamer, ikelos, mplichta, n-roeser, orodruinlair, phobosk, silvio.gerli |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 641780 | ||
Bug Blocks: | |||
Attachments: |
pitivi-0.98.1-fix-pycairo.patch
pitivi-0.98.1-r1.ebuild |
Description
Juergen Rose
2018-06-27 07:19:01 UTC
I confirm, the same with me Problem is still present. did you understand the reason and solution? same issue as well here This upstream patch fixes the issue: https://gitlab.gnome.org/GNOME/pitivi/commit/0f3e399e387e64dcc3c5015a8aacb26fbe49800f?view=inline (In reply to PhobosK from comment #4) > This upstream patch fixes the issue: > https://gitlab.gnome.org/GNOME/pitivi/commit/ > 0f3e399e387e64dcc3c5015a8aacb26fbe49800f?view=inline Fails for me with * Applying pitivi-0.98.1-optional-tests.patch ... [ ok ] * Applying pycairo-1.17.patch ... patch: **** Only garbage was found in the patch input. [ !! ] * ERROR: media-video/pitivi-0.98.1::gentoo failed (prepare phase): * patch -p1 failed with /etc/portage/patches/media-video/pitivi/pycairo-1.17.patch * * Call stack: * ebuild.sh, line 124: Called src_prepare * environment, line 4034: Called default * phase-functions.sh, line 868: Called default_src_prepare * phase-functions.sh, line 933: Called __eapi6_src_prepare * environment, line 408: Called eapply_user * environment, line 1004: Called eapply '/etc/portage/patches/media-video/pitivi/pycairo-1.17.patch' * environment, line 974: Called _eapply_patch '/etc/portage/patches/media-video/pitivi/pycairo-1.17.patch' * environment, line 912: Called __helpers_die 'patch -p1 failed with /etc/portage/patches/media-video/pitivi/pycairo-1.17.patch' * isolated-functions.sh, line 121: Called die * The specific snippet of code: * die "$@" this was what i put in patch file #include <py3cairo.h> #include <gst/gst.h> static Pycairo_CAPI_t *Pycairo_CAPI; static GObjectClass * gobject_class; /* Ok good now, seems i needed to click plain diff on top right corner to get right format... that one indeed worked and allowed it to build. diff --git a/pitivi/coptimizations/renderer.c b/pitivi/coptimizations/renderer.c index c655ca5cf71525e8a98c0783fcad96268a34d4d7..2f93941234513723c27e399e3438e6c4af1839db 100644 --- a/pitivi/coptimizations/renderer.c +++ b/pitivi/coptimizations/renderer.c @@ -4,7 +4,6 @@ #include <py3cairo.h> #include <gst/gst.h> -static Pycairo_CAPI_t *Pycairo_CAPI; static GObjectClass * gobject_class; /* Created attachment 568314 [details]
pitivi-0.98.1-fix-pycairo.patch
pitivi-0.98.1-fix-pycairo.patch
Created attachment 568316 [details]
pitivi-0.98.1-r1.ebuild
pitivi-0.98.1-r1.ebuild
Michal Plichta thanks for your patch and proposed ebuild. I'm going to add it to my local overlay. please retry with 0.999, it looks to work fine for me 0.999 failed form me: * Applying pitivi-0.999-optional-tests.patch ... /var/tmp/portage/media-video/pitivi-0.999/temp/environment: line 755: /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch: No such file or directory [ !! ] * ERROR: media-video/pitivi-0.999::gentoo failed (prepare phase): * patch -p1 failed with /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch * * Call stack: * ebuild.sh, line 124: Called src_prepare * environment, line 2350: Called default * phase-functions.sh, line 868: Called default_src_prepare * phase-functions.sh, line 933: Called __eapi6_src_prepare * environment, line 327: Called eapply '/var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch' * environment, line 820: Called _eapply_patch '/var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch' * environment, line 758: Called __helpers_die 'patch -p1 failed with /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch' * isolated-functions.sh, line 119: Called die * The specific snippet of code: * die "$@" * * If you need support, post the output of `emerge --info '=media-video/pitivi-0.999::gentoo'`, * the complete build log and the output of `emerge -pqv '=media-video/pitivi-0.999::gentoo'`. * The complete build log is located at '/var/log/portage/media-video:pitivi-0.999:20190331-135848.log'. * For convenience, a symlink to the build log is located at '/var/tmp/portage/media-video/pitivi-0.999/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/media-video/pitivi-0.999/temp/environment'. * Working directory: '/var/tmp/portage/media-video/pitivi-0.999/work/pitivi-0.999' * S: '/var/tmp/portage/media-video/pitivi-0.999/work/pitivi-0.999' The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d2ac57559f8cb4f3db21eabae381141e4b71638 commit 6d2ac57559f8cb4f3db21eabae381141e4b71638 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2019-03-31 23:30:07 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2019-03-31 23:30:17 +0000 media-video/pitivi: Add patch missed in previous commit Bug: https://bugs.gentoo.org/659332 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Pacho Ramos <pacho@gentoo.org> .../pitivi/files/pitivi-0.999-optional-tests.patch | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (In reply to Pacho Ramos from comment #11) > please retry with 0.999, it looks to work fine for me pitivi-0.999 works for me. Yes, after syncing 0.999 works, if you ask me you can close this bug I believe stable is still broken, so the bug is still valid in that sense. |