Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 659332

Summary: media-video/pitivi-0.98.1 (with pycairo-1.17.0) - static declaration of ‘Pycairo_CAPI’ follows non-static declaration static Pycairo_CAPI_t *Pycairo_CAPI
Product: Gentoo Linux Reporter: Juergen Rose <rose>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo, gstreamer, ikelos, mplichta, n-roeser, orodruinlair, phobosk, silvio.gerli
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 641780    
Bug Blocks:    
Attachments: pitivi-0.98.1-fix-pycairo.patch
pitivi-0.98.1-r1.ebuild

Description Juergen Rose 2018-06-27 07:19:01 UTC
'MAKEOPTS=-j1 emerge -pv1 pitivi' fails with:
...
FAILED: renderer@sha/pitivi_coptimizations_renderer.c.o 
x86_64-pc-linux-gnu-gcc -Irenderer@sha -I. -I../pitivi-0.98.1 -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/python3.5m -I/usr/include/pycairo -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -march=amdfam10 -O2 -fPIC -pthread  -MD -MQ 'renderer@sha/pitivi_coptimizations_renderer.c.o' -MF 'renderer@sha/pitivi_coptimizations_renderer.c.o.d' -o 'renderer@sha/pitivi_coptimizations_renderer.c.o' -c ../pitivi-0.98.1/pitivi/coptimizations/renderer.c
../pitivi-0.98.1/pitivi/coptimizations/renderer.c:7:24: error: static declaration of ‘Pycairo_CAPI’ follows non-static declaration
 static Pycairo_CAPI_t *Pycairo_CAPI;
                        ^~~~~~~~~~~~
In file included from ../pitivi-0.98.1/pitivi/coptimizations/renderer.c:4:0:
/usr/include/pycairo/py3cairo.h:262:17: note: previous declaration of ‘Pycairo_CAPI’ was here
 Pycairo_CAPI_t *Pycairo_CAPI;
                 ^~~~~~~~~~~~
[14/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/importingmpegts.page --output help/cs/importingmpegts.page
[15/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/importing.page --output help/cs/importing.page
[16/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/index.page --output help/cs/index.page
[17/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/keyframecurves.page --output help/cs/keyframecurves.page
[18/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/license.page --output help/cs/license.page
[19/220] /usr/bin/itstool -m help/cs/cs.mo ../pitivi-0.98.1/help/cs/../C/layers.page --output help/cs/layers.page
ninja: build stopped: subcommand failed.
 * ERROR: media-video/pitivi-0.98.1::gentoo failed (compile phase):





root@caiman:/root(13)# emerge --info '=media-video/pitivi-0.98.1::gentoo'
Portage 2.3.40 (python 3.5.5-final-0, default/linux/amd64/17.0, gcc-7.3.0, glibc-2.27-r5, 4.17.2-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.17.2-gentoo-x86_64-AMD_Phenom-tm-_II_X6_1090T_Processor-with-gentoo-2.6
KiB Mem:    16168252 total,   2083536 free
KiB Swap:  100663280 total, 100661232 free
Timestamp of repository gentoo: Wed, 27 Jun 2018 02:00:01 +0000
Head commit of repository gentoo: 6426bc47404d7832d2d8ca469b351c51652f98cc
sh bash 4.4_p23
ld GNU ld (Gentoo 2.30 p3) 2.30.0
app-shells/bash:          4.4_p23::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.15::gentoo, 3.5.5-r1::gentoo, 3.6.5-r1::gentoo
dev-util/cmake:           3.11.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.13.4-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r3::gentoo
sys-devel/gcc:            7.3.0-r3::gentoo
sys-devel/gcc-config:     1.9.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.17::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r5::gentoo
Repositories:

gentoo
    location: /usr/portage_caiman
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

g-cpan
    location: /var/lib/cpan
    masters: gentoo
    priority: 1

g-octave
    location: /var/lib/g-octave
    masters: gentoo
    priority: 2

science
    location: /var/lib/layman/science
    masters: gentoo
    priority: 50

x11
    location: /var/lib/layman/x11
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA PUEL Intel-SDP dlj-1.1 skype-eula skype-4.0.0.7-copyright googleearth AdobeFlash-11.x cadsoft Oracle-BCLA-JavaSE MakeMKV-EULA NVIDIA-CUDA Nero-AAC-EULA GIMPS"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=amdfam10 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=amdfam10 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs clean-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="de en fr ru"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="3dnow 3dnowext 64bit R X Xaw3d a52 aac acl acpi admin afs alsa amd64 amr ao apache2 apng applet archive armadillo arpack asf aspell assistant atlas audiofile automap automount barcode bash-completion berkdb blas blast bluetooth bluray boost btrfs bzip2 cairo cdda cddb cdf cdio cdparanoia cdr cgi chm cilk clang cli cmake collada contrib crypt css cups curl cxx daap db dbi dbm dbus declarative designer devhelp device-mapper dga dia digitalradio djvu doc dot dri ds2490 ds9097 ds9097u dts dv dvb dvd dvdr dvi dynamicplugin eds egl elf emacs emboss emf encode epiphany evdev evo examples excel exif expat extensions extra extras faac faad fam ffmpeg fftw firefox fits flac fltk fontconfig foomaticdb fortran fortran95 fpm fpx ftp fuse gcj gd gdal gdbm gedit geoip geolocation geos gfortran gif gimp git glade glamor glib glpk gml gmp gnome gnome-keyring gnuplot gnutls gold gphoto2 gpm grammar graphics graphtft graphviz grass gsl gsm gstreamer gtk gtk3 gudev guile hddtemp hdf hdf5 hdri html http httpd hvm hwdb iconv icq icu id3tag ide imagemagick imap inotify introspection ipod ipv6 irda ithreads jadetex java jbig jit john jpeg jpeg2k kate kdepim kdrive kerberos keymap kpathsea kvm ladspa lame lapack latex lcms ldap lensfun libffi libgda libkms libnotify libsamplerate libtirpc live lm_sensors lua lzma lzo mad mail maildir mapnik math matroska media-library mercurial mikmod mng mod modules mono motif mozilla mp3 mp4 mpeg mpi mpi-threads mplayer mtp multilib multimedia musepack musicbrainz mysql mysqli nautilus ncurses netcdf netpbm network networking nfs nls nntp nptl nsplugin ntfs ntp numpy obex objc ocaml ocr octave odbc ofa ogdi ogg opencl opencv openexr opengl openmp openvg pam pango pcre pda pdf pdl2 perl plasma plotutils plugins png podcast policykit portaudio posix postgres postscript ppds ppp preview-latex proj projectm pstricks pulseaudio python q16 q32 qemu qhull qml qt5 quicktime raw readline reiserfs reports rle romio rpc rrdcgi rrdtool sage samba sasl schroedinger science sdk sdl seccomp secure-delete server session shout sip slang slp smart smbclient smp sms sndfile snmp soap sockets sound soup sox speex spell sql sqlite ssl stlport subtitles subversion sudo suexec svg svm swig systemd szip t1lib tbb tcl tcpd tex tex4ht theora thesaurus threads thunderbird tidy tiff tk tools truetype udev udisks unicode usb utempter v4l v4l2 vaapi vala valgrind vdpau video vim-syntax virt-network virtualbox visio vorbis vpx vtk wav wayland webdav webdav-serf webkit wmf wxwidgets x264 xa xattr xcb xen xetex xft xine xml xmlreader xmlrpc xpm xv xvid xvmc yaml youtube zlib zsh-completion zvbi" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_core authn_dbm authn_default authn_file authz_core authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgid dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info lbmethod_byrequests log_config logio mem_cache mime mime_magic negotiation proxy proxy_ajp proxy_balancer proxy_connect proxy_http rewrite setenvif slotmem_shm so socache_shmcb speling status unique_id unixd userdir usertrack vhost_alias" APACHE2_MPMS="worker" CALLIGRA_FEATURES="karbon plan sheets stage words" CAMERAS="canon fuji ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="3dnow 3dnowext mmx mmxext popcnt sse sse2 sse3 sse4a" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="emu efi-64 pc xen" INPUT_DEVICES="keyboard mouse evdev void" KERNEL="linux" L10N="de en fr ru" LCD_DEVICES="cfontz hd44780 mtxorb ncurses X lcd2usb lcdlinux png usblcd SureElec" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="devinput" LLVM_TARGETS="AMDGPU X86" NETBEANS_MODULES="apisupport cnd dlight enterprise ergonomics groovy gsf harness ide identity j2ee java mobility nb php profiler websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5 postgres10" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5 python3_6" QEMU_SOFTMMU_TARGETS="arm i386 x86_64" QEMU_USER_TARGETS="arm i386 x86_64" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="radeon displaylink" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

media-video/pitivi-0.98.1::gentoo was built with the following:
USE="v4l -test" ABI_X86="(64)" PYTHON_SINGLE_TARGET="python3_5 -python3_4" PYTHON_TARGETS="python3_5 -python3_4"





root@caiman:/root(14)# emerge -pqv '=media-video/pitivi-0.98.1::gentoo'
[ebuild   R   ] media-video/pitivi-0.98.1  USE="v4l {-test}" PYTHON_SINGLE_TARGET="python3_5 -python3_4 -python3_6%" PYTHON_TARGETS="python3_5 python3_6%* -python3_4"
Comment 1 Silvio 2018-07-01 16:37:13 UTC
I confirm, the same with me
Comment 2 Silvio 2018-07-09 15:04:47 UTC
Problem is still present.
did you understand the reason and solution?
Comment 3 Denis Descheneaux 2018-07-15 20:38:15 UTC
same issue as well here
Comment 4 PhobosK 2018-07-27 20:31:55 UTC
This upstream patch fixes the issue:
https://gitlab.gnome.org/GNOME/pitivi/commit/0f3e399e387e64dcc3c5015a8aacb26fbe49800f?view=inline
Comment 5 Denis Descheneaux 2018-08-12 21:20:40 UTC
(In reply to PhobosK from comment #4)
> This upstream patch fixes the issue:
> https://gitlab.gnome.org/GNOME/pitivi/commit/
> 0f3e399e387e64dcc3c5015a8aacb26fbe49800f?view=inline

Fails for me with

 * Applying pitivi-0.98.1-optional-tests.patch ...                                                                 [ ok ]
 * Applying pycairo-1.17.patch ...
patch: **** Only garbage was found in the patch input.                                                             [ !! ]
 * ERROR: media-video/pitivi-0.98.1::gentoo failed (prepare phase):
 *   patch -p1  failed with /etc/portage/patches/media-video/pitivi/pycairo-1.17.patch
 * 
 * Call stack:
 *               ebuild.sh, line  124:  Called src_prepare
 *             environment, line 4034:  Called default
 *      phase-functions.sh, line  868:  Called default_src_prepare
 *      phase-functions.sh, line  933:  Called __eapi6_src_prepare
 *             environment, line  408:  Called eapply_user
 *             environment, line 1004:  Called eapply '/etc/portage/patches/media-video/pitivi/pycairo-1.17.patch'
 *             environment, line  974:  Called _eapply_patch '/etc/portage/patches/media-video/pitivi/pycairo-1.17.patch'
 *             environment, line  912:  Called __helpers_die 'patch -p1  failed with /etc/portage/patches/media-video/pitivi/pycairo-1.17.patch'
 *   isolated-functions.sh, line  121:  Called die
 * The specific snippet of code:
 *   		die "$@"
Comment 6 Denis Descheneaux 2018-08-12 21:22:22 UTC
this was what i put in patch file

#include <py3cairo.h>
#include <gst/gst.h>

static Pycairo_CAPI_t *Pycairo_CAPI;
static GObjectClass * gobject_class;

/*
Comment 7 Denis Descheneaux 2018-08-13 02:49:36 UTC
Ok good now, seems i needed to click plain diff on top right corner to get right format... that one indeed worked and allowed it to build.

diff --git a/pitivi/coptimizations/renderer.c b/pitivi/coptimizations/renderer.c
index c655ca5cf71525e8a98c0783fcad96268a34d4d7..2f93941234513723c27e399e3438e6c4af1839db 100644
--- a/pitivi/coptimizations/renderer.c
+++ b/pitivi/coptimizations/renderer.c
@@ -4,7 +4,6 @@
 #include <py3cairo.h>
 #include <gst/gst.h>
 
-static Pycairo_CAPI_t *Pycairo_CAPI;
 static GObjectClass * gobject_class;
 
 /*
Comment 8 Michal Plichta 2019-03-09 14:13:49 UTC
Created attachment 568314 [details]
pitivi-0.98.1-fix-pycairo.patch

pitivi-0.98.1-fix-pycairo.patch
Comment 9 Michal Plichta 2019-03-09 14:14:12 UTC
Created attachment 568316 [details]
pitivi-0.98.1-r1.ebuild

pitivi-0.98.1-r1.ebuild
Comment 10 Samuel Bernardo 2019-03-10 15:37:10 UTC
Michal Plichta thanks for your patch and proposed ebuild.
I'm going to add it to my local overlay.
Comment 11 Pacho Ramos gentoo-dev 2019-03-31 12:16:57 UTC
please retry with 0.999, it looks to work fine for me
Comment 12 Michal Plichta 2019-03-31 15:11:22 UTC
0.999 failed form me:

 * Applying pitivi-0.999-optional-tests.patch ...
/var/tmp/portage/media-video/pitivi-0.999/temp/environment: line 755: /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch: No such file or directory                                                                                                                               [ !! ]
 * ERROR: media-video/pitivi-0.999::gentoo failed (prepare phase):
 *   patch -p1  failed with /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch
 * 
 * Call stack:
 *               ebuild.sh, line  124:  Called src_prepare
 *             environment, line 2350:  Called default
 *      phase-functions.sh, line  868:  Called default_src_prepare
 *      phase-functions.sh, line  933:  Called __eapi6_src_prepare
 *             environment, line  327:  Called eapply '/var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch'
 *             environment, line  820:  Called _eapply_patch '/var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch'
 *             environment, line  758:  Called __helpers_die 'patch -p1  failed with /var/tmp/portage/media-video/pitivi-0.999/files/pitivi-0.999-optional-tests.patch'
 *   isolated-functions.sh, line  119:  Called die
 * The specific snippet of code:
 *   		die "$@"
 * 
 * If you need support, post the output of `emerge --info '=media-video/pitivi-0.999::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=media-video/pitivi-0.999::gentoo'`.
 * The complete build log is located at '/var/log/portage/media-video:pitivi-0.999:20190331-135848.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/media-video/pitivi-0.999/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/media-video/pitivi-0.999/temp/environment'.
 * Working directory: '/var/tmp/portage/media-video/pitivi-0.999/work/pitivi-0.999'
 * S: '/var/tmp/portage/media-video/pitivi-0.999/work/pitivi-0.999'
Comment 13 Larry the Git Cow gentoo-dev 2019-03-31 23:30:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d2ac57559f8cb4f3db21eabae381141e4b71638

commit 6d2ac57559f8cb4f3db21eabae381141e4b71638
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2019-03-31 23:30:07 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2019-03-31 23:30:17 +0000

    media-video/pitivi: Add patch missed in previous commit
    
    Bug: https://bugs.gentoo.org/659332
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 .../pitivi/files/pitivi-0.999-optional-tests.patch     | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 14 Juergen Rose 2019-04-01 11:41:29 UTC
(In reply to Pacho Ramos from comment #11)
> please retry with 0.999, it looks to work fine for me

pitivi-0.999 works for me.
Comment 15 Michal Plichta 2019-04-01 17:12:14 UTC
Yes, after syncing 0.999 works, if you ask me you can close this bug
Comment 16 Mart Raudsepp gentoo-dev 2019-04-02 06:42:53 UTC
I believe stable is still broken, so the bug is still valid in that sense.