| Summary: | media-sound/guayadeque - questionable media-libs/gnonlin dependency, review gstreamer deps | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Mart Raudsepp <leio> |
| Component: | Current packages | Assignee: | Professional Audio Applications Maintainers <proaudio> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | fordfrog, gstreamer |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 745393 | ||
| Bug Blocks: | |||
|
Description
Mart Raudsepp
2018-06-21 09:11:39 UTC
The following gstreamer elements are created explicitly in guayadeque source code (some of these could easily be runtime optional, I'm not checking into details of any):
audioconvert
audioresample
chromaprint
decodebin
equalizer-10bands
faac
fakesink
ffenc_wmav2
ffmux_asf
ffmux_mp4
filesink
filesrc
flacenc
giosrc
lamemp3enc
level
oggmux
playbin
queue
rglimiter
rgvolume
tee
volume
vorbisenc
xingmux
The following command should tell what package ships a given element, provided the element plugin is installed on the system:
gst-inspect-1.0 audioconvert |grep Filename |awk '{print $2}' |xargs qfile -eq
Running that in a loop for all of these, sorting and getting unique ones gives this list of potentially used by guayadeque gstreamer packages (version changed to SLOT):
No such element or plugin 'chromaprint'
No such element or plugin 'ffenc_wmav2'
No such element or plugin 'ffmux_asf'
No such element or plugin 'ffmux_mp4'
media-libs/gst-plugins-base:1.0
media-libs/gst-plugins-good:1.0
media-libs/gst-plugins-ugly:1.0
media-libs/gstreamer:1.0
media-plugins/gst-plugins-faac:1.0
media-plugins/gst-plugins-flac:1.0
media-plugins/gst-plugins-lame:1.0
As seen, I don't have packages for 4 elements, and I have all gstreamer packages installed.
chromaprint is a plugin with external deps from gst-plugins-bad that's not yet packaged. This will be packaged soon for other reasons as media-plugins/gst-plugins-chromaprint; probably today or tomorrow or so.
The ffenc_*/ffmux_* do not exist anymore. They were named as such with gstreamer-0.10 in gst-plugins-ffmpeg, but in 1.0 world they are in gst-plugins-libav as avenc_* and avmux_*, so this is upstream being broken for gstreamer 1.0 still in this respect.
Additionally there's a configurable or autoconfigured output audio sink, which is picked from the following list (element name, followed by the package that provides the element in Gentoo):
autoaudiosink - media-libs/gst-plugins-good:1.0
gconfaudiosink - does not exist for 1.0 (another 0.10 remnant in guayadeque)
alsasink - media-libs/gst-plugins-base:1.0[alsa]
pulsesink - media-plugins/gst-plugins-pulse:1.0
osssink - media-plugins/gst-plugins-oss:1.0
The code that handles this is in src/audio/FaderPlaybin.cpp - it looks like a prioritized list of things to try when autoconfigured, or manually settable somewhere by user. I think gst-plugins-meta should be good enough to cover it, instead of exposing own USE flags for this in guayadeque. Some of the other stuff above might be OK to leave to gst-plugins-meta too, though this is mainly meant for playbin/decodebin/uridecodebin usages - but guayadeque does use decodebin as well.
I think gnonlin used to provide some plugins, but at least nowadays it's just a libgnl.so, which I can't see guayadeque using. I think that dep can be removed, and the rest of gstreamer deps can be reviewed per the information above.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=96720b82caced823b5f52e6fd83d1d088e79854b commit 96720b82caced823b5f52e6fd83d1d088e79854b Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-29 15:51:42 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-29 15:52:32 +0000 media-sound/guayadeque: bump to 0.4.6 + updated live 1) eapi7 2) dropped media-libs/gnonlin:1.0 dep 3) updated and organized deps 4) fixed metadata installation 5) added xdg Bug: https://bugs.gentoo.org/724554 Bug: https://bugs.gentoo.org/658636 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/guayadeque/Manifest | 1 + .../guayadeque/files/guayadeque-0.4.6-gcc10.patch | 70 ++++++++++++++ .../files/guayadeque-0.4.6-metadata.patch | 13 +++ media-sound/guayadeque/guayadeque-0.4.6.ebuild | 105 +++++++++++++++++++++ media-sound/guayadeque/guayadeque-9999.ebuild | 51 +++++----- 5 files changed, 212 insertions(+), 28 deletions(-) not closing because of the suggested check of used plugins which i did not do. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c10dae9d9e4f1a627eb6ba89e3f66f69f98bc4ab commit c10dae9d9e4f1a627eb6ba89e3f66f69f98bc4ab Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-10-09 16:10:00 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-10-09 16:10:00 +0000 media-sound/guayadeque: removed obsolete 0.4.5_p20170110 Closes: https://bugs.gentoo.org/724554 Closes: https://bugs.gentoo.org/658636 Package-Manager: Portage-3.0.8, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/guayadeque/Manifest | 1 - .../guayadeque/guayadeque-0.4.5_p20170110.ebuild | 94 ---------------------- 2 files changed, 95 deletions(-) |