Summary: | sys-libs/zlib[minizip] should not install <minizip/crypt.h> | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | cyrillic <cyrilmaley> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ao, asturm |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/madler/zlib/pull/229 | ||
See Also: |
https://github.com/madler/zlib/pull/229 https://bugs.gentoo.org/show_bug.cgi?id=659416 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
zlib-1.2.11-r2.ebuild
ebuild.diff internal_crypt_header.patch ebuild.diff |
Description
cyrillic
2018-06-19 21:34:57 UTC
Created attachment 536462 [details]
zlib-1.2.11-r2.ebuild
the zlib sources themselves install this header. we should patch the source & send it upstream if it really is an internal header. Comment on attachment 536462 [details]
zlib-1.2.11-r2.ebuild
please attach diffs, not entire ebuilds. it's very hard to review entire files when you only change one or two lines.
Created attachment 536486 [details, diff] ebuild.diff (In reply to SpanKY from comment #2) > we should patch the source > & send it upstream if it really is an internal header. I agree. Not sure why RedHat did not think of that ... Just had a scribus build failure as a result of this, your ebuild fixed it. Comment on attachment 536486 [details, diff]
ebuild.diff
since we need to always generate minizip autotools, can you patch contrib/minizip/Makefile.am instead ? move crypt.h to a noinst var instead.
then you can e-mail it upstream (for proper credit) and we can merge it here linking to the upstream mailing list thread
Created attachment 536634 [details, diff] internal_crypt_header.patch My mistake, RedHat did try to fix this the right way, but their patch has not been accepted upstream yet. https://github.com/madler/zlib/pull/229 Created attachment 536636 [details, diff]
ebuild.diff
The current zlib ebuild ignores user patches.
thanks for tracking that down The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89cbe844bb4c4363270c692f50df5741cc2e78d7 commit 89cbe844bb4c4363270c692f50df5741cc2e78d7 Author: Mike Frysinger <vapier@gentoo.org> AuthorDate: 2018-06-21 02:55:38 +0000 Commit: Mike Frysinger <vapier@gentoo.org> CommitDate: 2018-06-21 02:57:06 +0000 sys-libs/zlib: drop install of minizip/crypt.h #658536 Closes: https://bugs.gentoo.org/658536 .../zlib-1.2.11-minizip-drop-crypt-header.patch | 38 +++++++ sys-libs/zlib/zlib-1.2.11-r2.ebuild | 123 +++++++++++++++++++++ 2 files changed, 161 insertions(+) *** Bug 658622 has been marked as a duplicate of this bug. *** |