Summary: | kernel-2.eclass: Migrate patching from src_unpack to src_prepare ebuild phase, deprecate EAPI<4 support | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Michael 'veremitz' Everitt <gentoo> |
Component: | Eclasses | Assignee: | Gentoo Kernel Bug Wranglers and Kernel Maintainers <kernel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kernel |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=473880 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | Move patch logic |
Description
Michael 'veremitz' Everitt
2018-06-12 02:17:36 UTC
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b73ebd9ac730549bb9edf5e8f9ff6614d08726a commit 3b73ebd9ac730549bb9edf5e8f9ff6614d08726a Author: Marty E. Plummer <hanetzer@startmail.com> AuthorDate: 2018-07-29 23:14:26 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2018-07-29 23:14:26 +0000 kernel-2.eclass: drop EAPI 0-1 support code Also went ahead and dropped versionator in favor of eapi7-ver for EAPI 0-6, and eutils for epatch. multilib dropped as unneeded. All ebuilds using it tested with ebuild clean install clean. Bug: https://bugs.gentoo.org/657926 Package-Manager: Portage-2.3.40, Repoman-2.3.9 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> eclass/kernel-2.eclass | 40 ++++++++++++++-------------------------- 1 file changed, 14 insertions(+), 26 deletions(-) (In reply to Larry the Git Cow from comment #1) > The bug has been referenced in the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=3b73ebd9ac730549bb9edf5e8f9ff6614d08726a > This only partially addresses the issue specified in the subject, which is part of PR #9064 (a wider cleanup). Re-opening for now, until more of this PR is ready for merging. what is still missing from here ? Created attachment 542822 [details]
Move patch logic
Here's a patch. But I still don't know if we really need this. At the moment it looks like a code change for nothing...
Michael, the link at : https://devmanual.gentoo.org/eclass-reference/ebuild/index.html Mentions patch in both unpack and prepare. Should we still rework this ? I think we're ok here and within documented guidelines. |