Bug 657300

Summary:	media-libs/soxr-0.1.3 - pkg-config version not set properly when IUSE "examples" is set
Product:	Gentoo Linux	Reporter:	PhobosK <phobosk>
Component:	Current packages	Assignee:	Gentoo Sound Team <sound>
Status:	RESOLVED FIXED
Severity:	normal	CC:	leonchik1976, phobosk
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	650748
Attachments:	soxr-fix_project_usage.patch soxr-0.1.3-r1.ebuild.diff

Description PhobosK 2018-06-03 20:00:49 UTC

Created attachment 534704 [details, diff]
soxr-fix_project_usage.patch

This bug affects several packages that use libsoxr:
- audacity (bug #651116)
- pulseaudio (bug #650748)
and maybe some others.

It appears because the upstream usage of the CMAKE project() in the CMakeLists.txt of media-libs/soxr is not proper.
What happens is that when IUSE "examples" (or the CMAKE variable BUILD_EXAMPLES) is set the pkg-config info in the installed .pc files about the version is set to ".." (i.e. empty). This makes other programs that rely on the lib to fail in the configuration phase....

This is one of the affected files:

# cat /usr/lib64/pkgconfig/soxr.pc
Name: soxr
Description: High quality, one-dimensional sample-rate conversion library
Version: ..
Libs: -L/usr/lib64 -lsoxr
Cflags: -I/usr/include


A workaround is just to unset the IUSE examples flag of soxr, but a better solution is to patch the necessary CMAKE file.

I am attaching the patch and the ebuild patch for media-libs/soxr-0.1.3
Probably the other versions will need it too...

I will report the bug upstream also...

Comment 1 PhobosK 2018-06-03 20:02:41 UTC

Created attachment 534720 [details, diff]
soxr-0.1.3-r1.ebuild.diff

The patch needed for the media-libs/soxr-0.1.3 ebuild

Comment 2 Andreas Sturmlechner gentoo-dev

2018-06-10 22:10:01 UTC

Thanks for your work, do you have an upstream link where we can track acceptance of your patch?

Comment 3 Larry the Git Cow gentoo-dev

2018-06-10 22:31:37 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e59fbe612bb92f9c8625dc187a5420a018df934

commit 0e59fbe612bb92f9c8625dc187a5420a018df934
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-06-10 22:21:12 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-06-10 22:30:13 +0000

    media-libs/soxr: Fix pkgconfig w/ USE=examples
    
    Thanks-to: PhobosK <phobosk@fastmail.fm>
    Closes: https://bugs.gentoo.org/657300
    Closes: https://bugs.gentoo.org/650748
    Closes: https://bugs.gentoo.org/651116
    Package-Manager: Portage-2.3.40, Repoman-2.3.9

 .../soxr/files/soxr-0.1.3-fix-pkgconfig.patch      | 25 +++++++++++
 media-libs/soxr/soxr-0.1.3-r1.ebuild               | 51 ++++++++++++++++++++++
 2 files changed, 76 insertions(+)

Comment 4 PhobosK 2018-06-11 18:03:40 UTC

Thanks...

@Andreas,
Since the author has disabled SF ticketing system in his soxr project, I couldn't report the bug in a real bug system, but today I put it in the discussion forum, so here is the link to it:

https://sourceforge.net/p/soxr/discussion/general/thread/5081f97d/