Summary: | www-client/firefox-60.0.1 tries to build Unified_cpp_common_audio_sse2_gn0.o.pp on arm64 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Roy Bamford <neddyseagoon> |
Component: | Current packages | Assignee: | Mozilla Gentoo Team <mozilla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | sakaki |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: |
https://bugzilla.mozilla.org/show_bug.cgi?id=1465274 https://bugs.gentoo.org/show_bug.cgi?id=758308 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
bz2 build log
Compressed raw build log Omit sse2 code from the build set on platforms that don't support it Fix skia build on arm64 with gcc |
Description
Roy Bamford
![]() Created attachment 534580 [details]
bz2 build log
Created attachment 534586 [details]
Compressed raw build log
This appears to be Mozilla bug #1434589 [1]. There's a large patch on that bug thread which addresses this, but also adds ppc64 support. I'll attach the relevant part of that patch to this thread now. Incidentally, there's another patch required to build arm64 firefox-60.0.1 under gcc (v6.4.0, at least), due to Mozilla bug #1453892 [2]. Please see my forum post [3] for further details. Best, sakaki [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1434589 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1453892 [3] https://forums.gentoo.org/viewtopic-t-1082036.html Created attachment 534740 [details, diff]
Omit sse2 code from the build set on platforms that don't support it
Both patches are required to build on arm64 with gcc-7.3 too. Created attachment 534760 [details, diff]
Fix skia build on arm64 with gcc
Here's the second patch mentioned above, for ease of reference (addresses Mozilla bug #1453892). Apologies for the slight OT, this may want to be in its own bug I guess.
(In reply to sakaki from comment #6) > Created attachment 534760 [details, diff] [details, diff] > Fix skia build on arm64 with gcc > > Here's the second patch mentioned above, for ease of reference (addresses > Mozilla bug #1453892). Apologies for the slight OT, this may want to be in > its own bug I guess. Thanks for the patches, I will work to add them into the build for esr60. We will not add to the patchset, after further investigating it has landed on the esr branch and the beta branch which will both have an update in next week or so. The patch got merged by upstream, so this bug can be closes I guess? :) (In reply to tt_1 from comment #9) > The patch got merged by upstream, so this bug can be closes I guess? :) Closing as I haven't seen this either. |