Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 656864

Summary: app-editors/nvi-1.81.6-r7 with >=sys-libs/ncurses-6.1 - segmentation fault when issuing ex or Q command
Product: Gentoo Linux Reporter: Gil Kloepfer <gbz>
Component: Current packagesAssignee: Felix Janda <felix.janda>
Severity: normal CC: pageexec, proxy-maint, treecleaner
Priority: Normal Keywords: PATCH, PMASKED
Version: unspecified   
Hardware: AMD64   
OS: Linux   
Package list:
Runtime testing required: ---
Bug Depends on: 690102    
Bug Blocks: 652080    
Deadline: 2020-03-18   
Attachments: Patch to cl/cl.h to include <term.h> when using ncurses

Description Gil Kloepfer 2018-05-29 17:52:18 UTC
Created attachment 534034 [details, diff]
Patch to cl/cl.h to include <term.h> when using ncurses

Since new version of ncurses released, nvi-1.81.6-r7 has been segfaulting whenever the 'Q' command is given, or the 'ex' command is given from the command line.  Review of the compiler output when nvi is compiled indicates that there are some missing function prototypes for tgoto/tputs that are from <term.h> that are not being included for cl/*.c (per gdb, the cause of this problem is in cl_screen.c).

Attached patch includes <term.h> when using ncurses, and provides the necessary prototypes that resolve the compiler warnings and resolve the segfault issues.
Comment 1 Gil Kloepfer 2018-05-29 17:55:04 UTC
emerge --info is below:

Portage 2.3.24 (python 2.7.14-final-0, default/linux/amd64/17.0, gcc-6.4.0, glibc-2.25-r11, 4.9.95-gentoo x86_64)
System uname: Linux-4.9.95-gentoo-x86_64-Intel-R-_Core-TM-_i7-2600_CPU_@_3.40GHz-with-gentoo-2.4.1
KiB Mem:     8151544 total,   3649784 free
KiB Swap:    4000180 total,   4000180 free
Timestamp of repository gentoo: Tue, 22 May 2018 03:15:01 +0000
Head commit of repository gentoo: 8104cc065493a6512f9a176f38ab49ccdfd1447d
Timestamp of repository arlut: Wed, 20 Sep 2017 12:11:30 +0000
Timestamp of repository arlut-git: Mon, 11 Sep 2017 19:41:27 +0000
Timestamp of repository kloepfer: Wed, 25 Apr 2018 15:33:27 +0000
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.24.3-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.5.5::gentoo
dev-util/cmake:           3.9.6::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.15.1-r2::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            6.4.0-r1::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r11::gentoo

    location: /space/sysbuild/portage
    sync-type: rsync
    sync-uri: rsync://
    priority: -1000
    sync-rsync-verify-metamanifest: no

    location: /space/sysbuild/arlut-overlay
    masters: gentoo

    location: /space/sysbuild/arlut-overlay-git
    masters: gentoo

    location: /space/sysbuild/kloepfer-overlay
    masters: gentoo

CFLAGS="-O2 -march=core2 -fomit-frame-pointer -fno-ident -pipe"
CONFIG_PROTECT="/etc /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/init.d/ /etc/revdep-rebuild /etc/sandbox.d /etc/ssl/certs /etc/terminfo"
CXXFLAGS="-O2 -march=core2 -fomit-frame-pointer -fno-ident -pipe"
EMERGE_DEFAULT_OPTS="--jobs=2 --load-average=3"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
INSTALL_MASK="/usr/lib/systemd /etc/systemd /lib/systemd"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
USE="X acl amd64 berkdb bzip2 cli crypt cxx dri gdbm iconv ipv6 mmx mmxext modules multilib ncurses nls nptl openmp pam pcre readline seccomp sse sse2 ssl ssse3 tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" L10N="en_US" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby23" USERLAND="GNU" VIDEO_CARDS="radeon r600 vesa vga" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Comment 2 Felix Janda 2018-06-01 15:58:48 UTC
Thanks for the patch!

For reference, could you also give the output of
`emerge --info app-editors/nvi`, give more detailled instructions of
how to reproduce the segfault (I cannot reproduce it), and attach the
build log with the compiler warnings?