Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 656818

Summary: x11-themes/gtk-engines-flat-2.0 bugs(memleak, crash on load)
Product: Gentoo Linux Reporter: tigsid <tigsidwork1>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: RESOLVED FIXED    
Severity: normal CC: asturm, treecleaner
Priority: Normal Keywords: PATCH, PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 698100    
Attachments: out patch for fix desc bugs

Description tigsid 2018-05-29 01:13:42 UTC 
Created attachment 533910 [details]
out patch for fix desc bugs

I like old flat gtk2 engine.
But code quality is not excellent.

1.
When libflat.so loading stand-alone, it is crash,
because not linked "libgtk".
It's affected in libreoffice, qt4-gtkstyle, may be in bug 632237.
I fix it by gtk-engines-flat-2.0-addgtklib.patch

2.
Engine have serious memleak,
because have not finalize func in "flat_style" class
and not free pre-created images.
It's rare affected,
but some times eats all available memory and crash xorg-server.
I fix it by gtk-engines-flat-2.0-memleak.01.patch
Also in this patch,
i disabled pre-render images creation when it's not necessary. 

Our patchs attached.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-08-15 20:25:08 UTC 
Doesn't sound too confidence inspiring.
Comment 2 Larry the Git Cow gentoo-dev 2021-10-16 17:38:03 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=766e448abf0ab42699f805bf47220d9d48a24a6e

commit 766e448abf0ab42699f805bf47220d9d48a24a6e
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2021-10-16 17:37:55 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-10-16 17:37:55 +0000

    profiles: last-rite x11-themes/gtk-engines-flat
    
    Bug: https://bugs.gentoo.org/632237
    Bug: https://bugs.gentoo.org/656818
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/package.mask | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2021-11-14 13:59:55 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=20ecd38f8e613b87841bf6f4c7b0e0552465dff3

commit 20ecd38f8e613b87841bf6f4c7b0e0552465dff3
Author:     Jakov Smolić <jsmolic@gentoo.org>
AuthorDate: 2021-11-14 13:57:48 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2021-11-14 13:58:55 +0000

    x11-themes/gtk-engines-flat: treeclean
    
    Closes: https://bugs.gentoo.org/656818
    Closes: https://bugs.gentoo.org/632237
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 profiles/package.mask                              |  6 ----
 x11-themes/gtk-engines-flat/Manifest               |  1 -
 .../gtk-engines-flat-2.0-r3.ebuild                 | 36 ----------------------
 x11-themes/gtk-engines-flat/metadata.xml           |  8 -----
 4 files changed, 51 deletions(-)