Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 656818

Summary: x11-themes/gtk-engines-flat-2.0 bugs(memleak, crash on load)
Product: Gentoo Linux Reporter: tigsid <tigsidwork1>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: UNCONFIRMED ---    
Severity: normal Keywords: PATCH
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: out patch for fix desc bugs

Description tigsid 2018-05-29 01:13:42 UTC
Created attachment 533910 [details]
out patch for fix desc bugs

I like old flat gtk2 engine.
But code quality is not excellent.

1.
When libflat.so loading stand-alone, it is crash,
because not linked "libgtk".
It's affected in libreoffice, qt4-gtkstyle, may be in bug 632237.
I fix it by gtk-engines-flat-2.0-addgtklib.patch

2.
Engine have serious memleak,
because have not finalize func in "flat_style" class
and not free pre-created images.
It's rare affected,
but some times eats all available memory and crash xorg-server.
I fix it by gtk-engines-flat-2.0-memleak.01.patch
Also in this patch,
i disabled pre-render images creation when it's not necessary. 

Our patchs attached.