| Summary: | games-board/freecell-solver: New package (required by kde-apps/kpat-18.08) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Andreas Sturmlechner <asturm> |
| Component: | New packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 1i5t5.duncan, eugene.shalygin, perfect007gentleman |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://fc-solve.shlomifish.org/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 661844 | ||
| Attachments: |
dev-libs/freecell-solver-4.20.0: minimal ebuild
games-board/freecell-solver-5.0.0: minimal ebuild games-board/freecell-solver-5.0.0: minimal ebuild games-board/freecell-solver-5.0.0: minimal ebuild |
||
|
Description
Andreas Sturmlechner
2018-05-24 14:27:09 UTC
*** Bug 656602 has been marked as a duplicate of this bug. *** The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=ea555a6c25c4c3ec7503de6d7d9263ef05a60070 commit ea555a6c25c4c3ec7503de6d7d9263ef05a60070 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2018-08-09 22:41:16 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-08-11 11:52:56 +0000 sets: Add KDE Applications 18.08 sets Not adding kpat as it depends on unpackaged games-board/freecell-solver. Bug: https://bugs.gentoo.org/656408 sets/kde-applications-18.08 | 21 ++++++++++++++++ sets/kde-baseapps-18.08 | 4 +++ sets/kdeaccessibility-18.08 | 4 +++ sets/kdeadmin-18.08 | 3 +++ sets/kdeedu-18.08 | 26 ++++++++++++++++++++ sets/kdegames-18.08 | 42 ++++++++++++++++++++++++++++++++ sets/kdegraphics-18.08 | 16 ++++++++++++ sets/kdemultimedia-18.08 | 12 +++++++++ sets/kdenetwork-18.08 | 24 ++++++++++++++++++ sets/kdepim-18.08 | 59 +++++++++++++++++++++++++++++++++++++++++++++ sets/kdesdk-18.08 | 15 ++++++++++++ sets/kdeutils-18.08 | 16 ++++++++++++ 12 files changed, 242 insertions(+) Created attachment 548290 [details]
dev-libs/freecell-solver-4.20.0: minimal ebuild
(In reply to Perfect Gentleman from comment #3) > Created attachment 548290 [details] > dev-libs/freecell-solver-4.20.0: minimal ebuild Thank you. It wouldn't merge as-is due to a bad LICENSE= line, and I didn't want the 50+ extra perl packages that the Template-Toolkit dep pulled in if there was a way around it, but given that I've been staring at the kpat-9999 live-ebuild fail at every update for nearing six months now without an official fix, I decided to try it, since six months is quite some time for a would-be "live" ebuild to be broken. For the LICENSE line, GPLv3 isn't correct for a couple reasons. First, the actual license is MIT/expat, according to the site (with a couple files having the 3-clause BSD license due to originating in a different project). Second, the license should match one of the existing file names in the (gentoo) repo licenses subdir, which means if it /were/ GPLv3, it'd be either GPL-3 or GPL-3+, depending on whether it included the "or later" conditional. But for the MIT/expat license, it's LICENSE=MIT (as confirmed by checking what the expat package uses). As for the 50+ deps pulled in by Template-Toolkit, they're perl, so don't really compile, so they go pretty fast. I still don't like them and will take the opportunity should it be offered to get rid of them via USE flag if the official build offers it, including the possibility of USE=-freecell or USE=-freecell-solver if I have to to kill the dep in kpat, but I'm willing to live with it temporarily, anyway, and will consider what to do as a more permanent solution once there's an official ebuild to base my consideration on. Meanwhile, I actually tried the ebuild as games-board/freecell-solver-5.0.0, the now-current release, and modified the kpat ebuild to add the games-board/freecell-solver dep, and kpat built against 5.0.0 just fine, despite it containing a potentially breaking change (includes are now in their own freecell-solver subdir). But that's not entirely surprising as the freecell-solver dev is now directly contributing to kpat as well. =:^) So kpat (at least the live-build kpat-9999) is confirmed to build and run, including checking the freecell solver using the demo function, against freecell-solver-5.0.0. =:^) Created attachment 553732 [details]
games-board/freecell-solver-5.0.0: minimal ebuild
Created attachment 553734 [details]
games-board/freecell-solver-5.0.0: minimal ebuild
Created attachment 553736 [details]
games-board/freecell-solver-5.0.0: minimal ebuild
(In reply to Perfect Gentleman from comment #7) > Created attachment 553736 [details] > games-board/freecell-solver-5.0.0: minimal ebuild Thanks for the update. Nice to have the license working now and the separate DEPEND/RDEPEND. Tested and confirmed working. =:^) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=efded93dd12ecf407990ddaaa9e2cd5f4029f358 commit efded93dd12ecf407990ddaaa9e2cd5f4029f358 Author: Michael Palimaka <kensington@gentoo.org> AuthorDate: 2019-04-12 14:07:54 +0000 Commit: Michael Palimaka <kensington@gentoo.org> CommitDate: 2019-04-12 14:16:51 +0000 dev-games/freecell-solver: new package Closes: https://bugs.gentoo.org/656408 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Michael Palimaka <kensington@gentoo.org> dev-games/freecell-solver/Manifest | 1 + .../freecell-solver/freecell-solver-5.6.0.ebuild | 46 ++++++++++++++++++++++ dev-games/freecell-solver/metadata.xml | 10 +++++ 3 files changed, 57 insertions(+) |