Bug 656182

Summary:	=www-client/firefox-{60,61}* fails to build with psutil.disk_io_counters() returning None
Product:	Gentoo Linux	Reporter:	Arfrever Frehtes Taifersar Arahesis <arfrever.fta>
Component:	Current packages	Assignee:	Mozilla Gentoo Team <mozilla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	arthur
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	All
URL:	https://bugzilla.mozilla.org/show_bug.cgi?id=1461221
Whiteboard:
Package list:		Runtime testing required:	---

Description Arfrever Frehtes Taifersar Arahesis 2018-05-20 19:53:41 UTC

www-client/firefox-60.0 fails to build with dev-python/psutil installed and psutil.disk_io_counters() returning None.
It occurs probably when /proc/diskstats is empty.

https://bugzilla.mozilla.org/show_bug.cgi?id=1461221
https://hg.mozilla.org/mozilla-central/rev/e4ce7b972916

Please include this patch in Gentoo patchset for www-client/firefox.


Build log ended with:


Error running mach:

    ['build', '--verbose']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: object of type 'NoneType' has no len()

  File "/var/tmp/portage/www-client/firefox-60.0/work/firefox-60.0/python/mozbuild/mozbuild/mach_commands.py", line 172, in build
    mach_context=self._mach_context)
  File "/var/tmp/portage/www-client/firefox-60.0/work/firefox-60.0/python/mozbuild/mozbuild/controller/building.py", line 942, in build
    monitor.init(warnings_path)
  File "/var/tmp/portage/www-client/firefox-60.0/work/firefox-60.0/python/mozbuild/mozbuild/controller/building.py", line 201, in init
    self.resources = SystemResourceMonitor(poll_interval=1.0)
  File "/var/tmp/portage/www-client/firefox-60.0/work/firefox-60.0/testing/mozbase/mozsystemmonitor/mozsystemmonitor/resourcemonitor.py", line 250, in __init__
    self._io_len = len(io)

Comment 1 Arfrever Frehtes Taifersar Arahesis 2018-06-28 20:07:10 UTC

Actually Firefox has its own copy of psutil.

Comment 2 Jory A. Pratt gentoo-dev

2018-06-28 21:42:55 UTC

Thanks, upstream patch is now applied to both versions.

Comment 3 Oleh 2018-10-30 07:47:05 UTC

Side note:
=thunderbird-60* suffers from the same problem and the patch fixes.

Comment 4 Arfrever Frehtes Taifersar Arahesis 2018-10-30 13:04:07 UTC

(In reply to Oleg from comment #3)
> Side note:
> =thunderbird-60* suffers from the same problem and the patch fixes.

I think that https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af6aa45d9abaef36b72811c9141beeda3f4f59d0 was missing in your ebuild.