| Summary: | nautilus 2.8.0 + libexif 0.6.10 won't compile | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Stephane Loeuillet <leroutier> |
| Component: | [OLD] GNOME | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | swtaylor |
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 13463 | ||
| Bug Blocks: | 64135, 66864 | ||
| Attachments: | fix nautilus 2.8.0 to work with libexif 0.6 | ||
|
Description
Stephane Loeuillet
2004-09-27 16:27:57 UTC
nautilus-image-properties-view.c:133:85: macro "exif_content_get_value" requires 4 arguments, but only 2 given nautilus-image-properties-view.c: In function `exif_content_callback': nautilus-image-properties-view.c:133: error: `exif_content_get_value' undeclared (first use in this function) nautilus-image-properties-view.c:133: error: (Each undeclared identifier is reported only once nautilus-image-properties-view.c:133: error: for each function it appears in.) make[3]: *** [nautilus-image-properties-view.lo] Erreur 1 make[3]: *** Attente des tâches non terminées.... make[3]: *** Attente des tâches non terminées.... make[3]: Leaving directory `/var/tmp/portage/nautilus-2.8.0/work/nautilus-2.8.0/components/image_properties' make[2]: *** [all-recursive] Erreur 1 make[2]: Leaving directory `/var/tmp/portage/nautilus-2.8.0/work/nautilus-2.8.0/components' make[1]: *** [all-recursive] Erreur 1 make[1]: Leaving directory `/var/tmp/portage/nautilus-2.8.0/work/nautilus-2.8.0' make: *** [all-recursive-am] Erreur 2 nautilus USE flags : -cups -debug +flac +gstreamer +mad +oggvorbis worked fine against libexif 0.5.12-r1 Reproducible: Always Steps to Reproduce: 1. USE="-cups -debug flac gstreamer mad oggvorbis" emerge nautilus Portage 2.0.51_rc6 (default-x86-2004.2, gcc-3.4.2, glibc-2.3.4.20040916-r0, 2.6.9-rc2 i686) ================================================================= System uname: 2.6.9-rc2 i686 AMD Athlon(tm) XP 2600+ Gentoo Base System version 1.5.3 Autoconf: sys-devel/autoconf-2.59-r4 Automake: sys-devel/automake-1.8.5-r1 Binutils: sys-devel/binutils-2.15.90.0.1.1-r3 Headers: sys-kernel/linux26-headers-2.6.8.1 Libtools: sys-devel/libtool-1.5.2-r5 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer" CHOST="i686-pc-linux-gnu" COMPILER="" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/bind /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=athlon-xp -O3 -pipe -fomit-frame-pointer" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs buildpkg ccache digest distlocks fixpackages sandbox strict userpriv" GENTOO_MIRRORS="ftp://ftp.ussg.iu.edu/pub/linux/gentoo" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage" USE="3dnow 3dnowex X aalib accessibility acpi adns alsa apache2 avi berkdb bitmap-fonts bonobo cdr crypt cups divx4linux doc dv dvb dvd dvdr dvdread eds encode erandom esd ethereal evo faac faad flac flash foomaticdb gd gdbm gif gimp gnome gnomedb gnutls gstreamer gtk gtk2 gtkhtml hal idea ieee1394 innodb irda irmc ithreads joystick jpeg ldap libcaca libg++ libgda libwww mad mikmod mmx mmx2 mozilla moznocompose moznoirc moznomail mozsvg mozxmlterm mpeg mysql ncurses net nls nntp nptl nvidia offensive oggvorbis opengl pam pcre pcsc-lite pda pdflib perl pic plotutils png postgres ppds pwdb python quicktime readline rtc samba sasl sdl slang sndfile speex spell sse ssl svg svga tcpd tetex theora threads tiff truetype unicode usb v4l v4l2 videos x86 xml xml2 xprint xv xvid xvmc yv12 zlib zvbi" Please see BUG #13463 ! Andreas, thanks for the bug pointer There are a handful of packages that at the very least need recompiled to use libexif.so.10 instead of libexif.so.9 (including eog and sane)... Could/should libexif be slotted to leave the old version around, or are there just going to be a few ebuilds needing patches conditional upon the version of libexif that is installed? for me, only eog, gimp, gthumb and perhaps a 4th one only required a rebuild to work against libexif 0.6.x nautilus 2.8.0 (and 2.6.x apparently) was the only one that broke The same thing happens with digikam 6.2. Created attachment 40696 [details, diff]
fix nautilus 2.8.0 to work with libexif 0.6
Added patch for compiling with libexif 0.6
It's basically the same as the one for nautilus 2.6 from the previous bug.
Tested on my box and works...
Just add the following to the ebuild to automagically detect libexif and apply
patch if necessary:
has_version '>=media-libs/libexif-0.6' && epatch
${FILESDIR}/${P}-libexif-0.6.patch
I can confirm that it also breaks digikam (which also won't emerge anymore so I can't just rebuild it) Upgrading libexif to the latest fixed the problem for me. We still need this patch when using libexif 0.6, which is currently not in portage but needed for some other software. Please apply to ebuild. Regards, Andy. This package is hard-masked for two reason: so people won't use it... but those brave ones will find bugs. We're not going to go around patching code here and there to work with the new version until a few things are clearer: does this need to be slotted? are upstream working with this new version (ie patching etc)? is this just a buggy version of libexif? (eradicator comments: "Backwards compatibility problems in the API"). Mike, libexif is version 0.6 for a long time now, almost any other linux distribution is using it instead of libexif-0.6. Suse/Slackware/Mandrake/Sourcerer/FreeBSD... Further it can be slotted since the library will be libexif.so.10 instead of libexif.so.9 it cannot be slotted, everything but the actual versioned .so's will clash. Upstream is <a href="http://bugzilla.gnome.org/show_bug.cgi?id=143743"> bug #143743 </a>. Adding/testing this now, not in that order. Applied now to nautilus-2.8.0, we can possibly backport this, but with libexif-0.6.10 still a bit off, it may not be necessary. |
