Bug 655440 – media-video/transcode-1.1.7 ffmpeg4 patch seems incomplete

• Product: Gentoo Linux
• Status: RESOLVED INVALID

[Description Ken Moffat 2018-05-11 04:25:46 UTC]

Created attachment 530778 [details, diff]
Enhanced patch for ffmpeg-4

I'm not one of your users, but your patches and other fixes have often helped me out so I hope o return the favour. You have ffmpeg-4.0 masked at the moment (if I have understood your terminology), but with a patch for building transcode with ffmpeg4 at  https://gitweb.gentoo.org/repo/gentoo.git/tree/media-video/transcode/files/ffmpeg4.patch?id=ac771a5dab7c52b1afa12e903b74b747737e9412

I'm on BLFS, we've already moved to ffmpeg-4.0 and transcode is the one remaining borken package. So I was very pleased to find your patch. But I've applied all your set of patches and using

./configure --prefix=/usr        \
            --enable-a52         \
            --enable-alsa        \
            --enable-freetype2   \
            --enable-imagemagick \ 
            --enable-libmpeg2    \
            --enable-libpostproc \ 
            --enable-x264        \
            --enable-xvid

I got a series of breakages. Mostly from incomplete changes, but I'll mention two others here: we were not using --enable-libavresample (we've had a *very* cut-down transcode for years, to provide tccat), and for the imnagemagick7 patch I had not spotted that it requires autoreconf to pick up the new configure.in.

For the remainder, several PIX_FMT_ needed to be changed to AV_PIX_FMT_.

Reworked patch is attached, builds and DESTDIR installs but not yet tested.

[Comment 1 Alexis Ballier 2018-05-11 14:35:28 UTC]

Thanks, but we've had that fix for some time already here:
http://distfiles.gentoo.org/distfiles/transcode-1.1.7-patchset.tar.bz2

it was needed for ffmpeg 2.9 according to the history.