| Summary: | [gnome overlay] app-crypt/seahorse-9999 is using meson now | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | cyrillic <cyrilmaley> |
| Component: | Current packages | Assignee: | Gentoo Linux Gnome Desktop Team <gnome> |
| Status: | RESOLVED OBSOLETE | ||
| Severity: | normal | CC: | gentoo |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
seahorse-9999.ebuild
seahorse-9999.ebuild meson.eclass.patch seahorse-9999.ebuild seahorse-9999.ebuild build.log seahorse-9999.ebuild ifdef_consistency.patch seahorse-9999.ebuild seahorse-9999.ebuild |
||
Created attachment 530554 [details]
seahorse-9999.ebuild
Converted to meson, this one works better.
(In reply to cyrillic from comment #1) > Created attachment 530554 [details] > seahorse-9999.ebuild > > Converted to meson, this one works better. the sed in src_prepare is unnecessary. other than that using meson_use and gnome_meson elcass isn't a bad idea. i don't see anything else wrong with it. please fix the src_prepare so i can push this :D Created attachment 534208 [details]
seahorse-9999.ebuild
In cleaning up this ebuild, I
- made src_configure more closely resemble upstream
- noticed that vala and ssh are no longer optional
- made better use of existing eclasses
Created attachment 534210 [details, diff]
meson.eclass.patch
I also moved USE="debug" out of the ebuild and into the eclass where it makes more sense.
... after that, I noticed that seahorse cannot build with USE="-debug", because there is something wrong with ldap. It would be nice if someone who actually knows what they are doing could look this over :)
Created attachment 534316 [details]
seahorse-9999.ebuild
Icon cache needed updating too.
Created attachment 534362 [details]
seahorse-9999.ebuild
gnome2-live.eclass is overrated, switching to git-r3.eclass
Created attachment 534364 [details]
build.log
This is what happens when USE="-debug"
I think some of the required headers are not getting included.
With USE="debug" everything seems to build and install fine.
Created attachment 534600 [details]
seahorse-9999.ebuild
Ok, now I understand why debug would not work from inside the ebuild.
It is because gnome-meson_src_configure was passing an empty emesonargs to meson_src_configure, so none of the options were having any effect.
So now, seahorse builds with USE="-debug -ldap", and no eclass modifications are needed.
There is still something broken with USE="ldap", but this could be filed as a separate bug once the ebuild is pushed.
(In reply to cyrillic from comment #4) > It would be nice if someone who > actually knows what they are doing could look this over :) When I re-read this, it sounded a bit insulting, but it was not directed at anyone. I was only admitting that I do not know what I am doing. Created attachment 537140 [details, diff]
ifdef_consistency.patch
The USE="ldap" mystery is solved. Apparently #if and #ifdef do not do the same thing. Using the right one was key to compiling LDAP support without having to enable the debugging code.
Created attachment 537142 [details]
seahorse-9999.ebuild
This one should be ready to push now that all useflag combinations are working.
I used your ebuild to build the latest tagged version 3.30.0. I only had to make small modifications: the dependencies app-crypt/gcr and app-crypt/libsecret need the USE flag "vala" enabled. With that, it compiles and starts, but is still a buggy mess. :/ Created attachment 555332 [details]
seahorse-9999.ebuild
Removed gnome-meson eclass because other Gnome overlay packages seem to be headed in this direction too.
Cleaned out the gnome-overlay a while ago. |
[gnome overlay] app-crypt/seahorse-9999 is using meson now Reproducible: Always >>> Source unpacked in /tmp/portage/app-crypt/seahorse-9999/work >>> Preparing source in /tmp/portage/app-crypt/seahorse-9999/work/seahorse-9999 ... sed: can't read configure.ac: No such file or directory