| Summary: | rpm.eclass should not inherit eutils for EAPI>=6 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Jonas Stein <jstein> |
| Component: | Eclasses | Assignee: | Gentoo's Team for Core System packages <base-system> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | leio |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | find_ebuild_with_rpmeclass_which_need_eutils.py | ||
The reason for the eutils inheritance is the rpm_spec_epatch function which calls "epatch". Dunno if it's feasible to call eapply in EAPI>=6 ebuilds as eapply defaults to -p1 epatch is available in epatch.eclass now instead of full eutils.eclass.
My blind suggestion would be to thus change it to
[[ ${EAPI} == [0123456] ]] && inherit epatch
and use eapply in that rpm_spec_epatch function for EAPI-7 if it's feasible to force -p1 on whatever that stuff does safely on EAPI bumps. Possibly also renaming it to rpm_spec_eapply with EAPI-7?
(In reply to Lars Wendler (Polynomial-C) from comment #1) > The reason for the eutils inheritance is the rpm_spec_epatch function which > calls "epatch". > Dunno if it's feasible to call eapply in EAPI>=6 ebuilds as eapply defaults > to -p1 Don't forget about estack eclass for eshopts_{push,pop} in srcrpm_unpack *** This bug has been marked as a duplicate of bug 655256 *** |
Created attachment 530410 [details] find_ebuild_with_rpmeclass_which_need_eutils.py I suggest to change: -inherit eutils +[[ ${EAPI} == [012345] ]] && inherit eutils I have searched with the attached script for ebuilds, which inherit rpm in EAPI=6, but need eutils and forgot to inherit it directly. None found. So it should not cause negative side effects.