Bug 655024

Summary:	media-libs/opencv-3.3.0-r5 API incompatible with >= media-video/ffmpeg-4.0
Product:	Gentoo Linux	Reporter:	Reuben Martin <reuben.m>
Component:	Current packages	Assignee:	Amy Liffey <amynka>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dilfridge, dschridde+gentoobugs, jstein, quentin
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	653678
Attachments:	build log opencv-3.3.0-ffmpeg-4.0-compatibility.patch

Description Reuben Martin 2018-05-05 23:54:56 UTC

See summary.

Reproducible: Always

Comment 1 Reuben Martin 2018-05-05 23:59:15 UTC

Created attachment 530058 [details]
build log

Relevant part of compiler output

Comment 2 Quentin Minster 2018-05-18 23:19:17 UTC

Created attachment 532102 [details, diff]
opencv-3.3.0-ffmpeg-4.0-compatibility.patch

Here is a patch fixing the build with >=media-video/ffmpeg-4.0.

It *should* also work with <media-video/ffmpeg-4.0, but I didn't check.

Comment 3 Carl Eugen Hoyos 2018-06-17 22:52:57 UTC

The first hunk of the patch is both wrong and unneeded:
The defines are not part of libavformat but libavcodec, AV_CODEC_FLAG_GLOBAL_HEADER was added in FFmpeg 2.8, AV_PKT_FLAG_KEY in FFmpeg 0.9.

Comment 4 Andreas Sturmlechner gentoo-dev

2018-09-16 11:49:17 UTC

ping

Comment 5 Amy Liffey gentoo-dev

2018-09-16 11:52:44 UTC

(In reply to Andreas Sturmlechner from comment #4)
> ping

Should be fine in 3.4.1?

Comment 6 Andreas Sturmlechner gentoo-dev

2018-09-21 15:14:46 UTC

(In reply to Amy Liffey from comment #5)
> Should be fine in 3.4.1?

Correct! Built fine with 3.4.1-r4.