Bug 655022 – www-client/firefox-59.0.2 with sys-devel/gcc-8.1.0-r1 - media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c:118:1: error: attributes should be specified before the declarator in a function definition

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description iGentoo 2018-05-05 23:53:16 UTC]

Created attachment 530056 [details]
firefox-59.0.2-build.log.xz

64:38.68 /var/tmp/portage/www-client/firefox-59.0.2/work/mozilla-release-239e434d6d2b8e1e2b697c3416d1e96d48fe98e5/media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c:118:1: error: attributes should be specified before the declarator in a function definition
64:38.68  static inline int32_t OverflowingMulS16ByS32ToS32(int16_t a, int32_t b)
64:38.68  ^~~~~~
64:38.68 /var/tmp/portage/www-client/firefox-59.0.2/work/mozilla-release-239e434d6d2b8e1e2b697c3416d1e96d48fe98e5/media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c: In function 'GmmProbability':
64:38.69 /var/tmp/portage/www-client/firefox-59.0.2/work/mozilla-release-239e434d6d2b8e1e2b697c3416d1e96d48fe98e5/media/webrtc/trunk/webrtc/common_audio/vad/vad_core.c:391:22: warning: implicit declaration of function 'OverflowingMulS16ByS32ToS32' [-Wimplicit-function-declaration]
64:38.69            tmp2_s32 = OverflowingMulS16ByS32ToS32(tmp_s16, tmp1_s32);
64:38.69                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
64:38.69 gmake[4]: *** [/var/tmp/portage/www-client/firefox-59.0.2/work/mozilla-release-239e434d6d2b8e1e2b697c3416d1e96d48fe98e5/config/rules.mk:774: vad_core.o] Error 1



Portage 2.3.36 (python 3.6.5-final-0, default/linux/amd64/17.1, gcc-8.1.0, glibc-2.27-r2, 4.16.7-gentoo.x86_64 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.16.7-gentoo.x86_64-x86_64-Intel-R-_Core-TM-2_Quad_CPU_Q9300_@_2.50GHz-with-gentoo-2.4.1
KiB Mem:     6112296 total,   1417404 free
KiB Swap:    6291452 total,   6088956 free
Head commit of repository gentoo: de37b19ab38f31db07f9aaa761fd7cc0e7748f5c

sh dash 0.5.9.1-r3
ld GNU gold (Gentoo 2.30 p2 2.30.0) 1.15
ccache version 3.4.2 [disabled]
app-shells/bash:          4.4_p19::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.26.2::gentoo
dev-lang/python:          2.7.14-r2::gentoo, 3.6.5-r1::gentoo
dev-util/ccache:          3.4.2::local-repo
dev-util/cmake:           3.11.1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.30-r2::gentoo
sys-devel/gcc:            8.1.0-r1::gentoo
sys-devel/gcc-config:     1.9.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r3::gentoo
sys-kernel/linux-headers: 4.16-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.27-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/gentoo.git
    sync-user: portage
    priority: -1000
    eclass-overrides: local-repo

local-repo
    location: /usr/local/portage
    masters: gentoo

Installed sets: @local
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-Wall -march=native -O2 -pipe -frecord-gcc-switches"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Wall -march=native -O2 -pipe -frecord-gcc-switches"
DISTDIR="/var/portage/distfiles"
EMERGE_DEFAULT_OPTS="--color=n --keep-going --oneshot"
FCFLAGS="-Wall -march=native -O2 -pipe -frecord-gcc-switches"
FEATURES="assume-digests binpkg-logs buildpkg collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync metadata-transfer multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms split-log strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-Wall -march=native -O2 -pipe -frecord-gcc-switches"
GENTOO_MIRRORS="https://mirrors.163.com/gentoo http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS="zh_CN"
MAKEOPTS="V=1 -j3"
PKGDIR="/var/portage/packages"
PORTAGE_BZIP2_COMMAND="lbzip2"
PORTAGE_COMPRESS="xz"
PORTAGE_COMPRESS_FLAGS="-9T0"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl amd64 audit berkdb bzip2 cli crypt cxx dbus dri egl fortran gdbm gles2 iconv icu ipv6 jpeg modules multilib ncurses nls nptl opengl openmp pam pax_kernel pcre pic png policykit pulseaudio readline seccomp ssl systemd tcpd unicode vdpau vim-syntax wayland xattr zlib" ABI_X86="64 32 x32" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon plan sheets stage words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 sse4_1 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="zh-CN" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby25" USERLAND="GNU" VIDEO_CARDS="nouveau nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, ENV_UNSET, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

www-client/firefox-59.0.2::gentoo was built with the following:
USE="custom-cflags custom-optimization dbus hwaccel pulseaudio screenshot system-harfbuzz system-icu system-jpeg system-libevent system-libvpx system-sqlite -bindist -debug -eme-free -gmp-autoupdate -hardened -jack (-neon) (-selinux) -startup-notification -test -wifi" ABI_X86="64" L10N="-ach -af -an -ar -as -ast -az -bg -bn-BD -bn-IN -br -bs -ca -cak -cs -cy -da -de -dsb -el -en-GB -en-ZA -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mai -mk -ml -mr -ms -nb -nl -nn -or -pa -pl -pt-BR -pt-PT -rm -ro -ru -si -sk -sl -son -sq -sr -sv -ta -te -th -tr -uk -uz -vi -xh -zh-CN -zh-TW"
CFLAGS="-Wall -march=native -pipe -frecord-gcc-switches"
CXXFLAGS="-Wall -march=native -pipe -frecord-gcc-switches -fno-delete-null-pointer-checks -fno-lifetime-dse -fno-schedule-insns2"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags"


sys-devel/gcc-8.1.0-r1::gentoo was built with the following:
USE="cxx fortran (multilib) nls nptl openmp pch (pie) sanitize ssp vtv (-altivec) -debug -doc (-fixed-point) -go -graphite (-hardened) (-jit) (-libssp) -mpx -objc -objc++ -objc-gc -pgo -regression-test -vanilla" ABI_X86="64"
CFLAGS="-Wall -march=native -O2 -pipe"
CXXFLAGS="-Wall -march=native -O2 -pipe"

[Comment 1 Martin Väth 2018-05-06 05:08:24 UTC]

Created attachment 530066 [details, diff]
Specify attribute before declarator

[Comment 2 Mike Lothian 2018-05-07 10:11:33 UTC]

The upstream fix is here: https://codereview.webrtc.org/2947383002

[Comment 3 Sergei Trofimovich (RETIRED) 2018-05-07 16:41:04 UTC]

firefox's merge of webrtc fix: https://github.com/mozilla/gecko-dev/commit/38a3ee1f792f586aef412ebc04980a93825612c9

[Comment 4 Larry the Git Cow 2018-05-11 16:01:48 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04dbda8f8b26fa328d7109fe48c5773086fc364e

commit 04dbda8f8b26fa328d7109fe48c5773086fc364e
Author:     Ian Stakenvicius <[e-mail]>
AuthorDate: 2018-05-11 15:49:49 +0000
Commit:     Ian Stakenvicius <[e-mail]>
CommitDate: 2018-05-11 16:00:58 +0000

    www-client/firefox: bump to v60
    
    Includes mozcoreconf-v6 and mozconfig-v6.60 eclasses
    
    Closes: http://bugs.gentoo.org/653678
    Closes: http://bugs.gentoo.org/655396
    Closes: http://bugs.gentoo.org/655022
    
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 eclass/mozconfig-v6.60.eclass                      | 396 +++++++++++++++++++++
 eclass/mozcoreconf-v6.eclass                       | 277 ++++++++++++++
 www-client/firefox/Manifest                        | 186 +++++-----
 .../{firefox-59.0.2.ebuild => firefox-60.0.ebuild} |  10 +-
 4 files changed, 771 insertions(+), 98 deletions(-)