Bug 653936 – dev-util/cmake-3.11.0: Incompatible FindBLAS.cmake module, BLAS_LIBRARIES contains "PkgConfig::PKGC_BLAS"

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Matthias Maier 2018-04-24 03:18:20 UTC]

For a long time we had our custom override of FindBLAS.cmake to use pkg config and everything was fine...

But then upstream changed this to their own PkgConfig call [1]. The problem is now that BLAS_LIBRARIES will be populated with the string "PkgConfig::PKGC_BLAS" instead of a semicolon separated list of actual libraries.

Now, this isn't that much of a problem as long as the string is directly passed as a library to a target. But unfortunately, there are a number of packages out there that expect BLAS_LIBRARIES to contain an actual list of libraries.


[1] https://gitlab.kitware.com/cmake/cmake/commit/a9c42e3ec09fa9cdf308344d12b0cc8c2e44d905

[Comment 1 Matthias Maier 2018-04-24 03:59:10 UTC]

Reference upstream bug report.

[Comment 2 François Bissey 2018-08-17 08:58:28 UTC]

It is not the only problem. https://github.com/gentoo/sci/issues/878
tl;dr
CMakeList.txt for cblas-reference and lapack-reference (same source) rely on the variable `BLAS_FOUND` to be returned not just `BLAS_LIBRARIES` to be returned by find_package(blas). But the new FindBLAS.cmake never sets BLAS_FOUND anymore - even so it is documented in the module.
There may be other like that out there.

[Comment 3 Andreas Sturmlechner 2018-08-26 11:18:12 UTC]

(In reply to François Bissey from comment #2)
> It is not the only problem. https://github.com/gentoo/sci/issues/878
> tl;dr
> CMakeList.txt for cblas-reference and lapack-reference (same source) rely on
> the variable `BLAS_FOUND` to be returned not just `BLAS_LIBRARIES` to be
> returned by find_package(blas). But the new FindBLAS.cmake never sets
> BLAS_FOUND anymore - even so it is documented in the module.
> There may be other like that out there.

I can confirm that issue for cmake-3.12.1, while cmake-3.11.4-r1 seems to work fine.

Rolf, are you aware of the problem? I could not find an upstream report for 3.12.

[Comment 4 Martin von Gagern 2018-11-18 11:11:00 UTC]

See https://gitlab.kitware.com/cmake/cmake/merge_requests/2631 for merge request I just wrote to restore BLAS_FOUND broken since [1].
Feel free to consider adding this as a distro-level patch in a revbump for now.

[1] https://gitlab.kitware.com/cmake/cmake/commit/92ac721a44bcae43ed9ad33d4d0f

[Comment 5 Larry the Git Cow 2018-11-21 09:35:19 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=160c412e439e3106ffb542beefa123816c72ec6d

commit 160c412e439e3106ffb542beefa123816c72ec6d
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2018-11-21 09:34:55 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2018-11-21 09:35:12 +0000

    dev-util/cmake: Bump to version 3.13.0. Removed old.
    
    Closes: https://bugs.gentoo.org/653936
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Lars Wendler <[e-mail]>

 dev-util/cmake/Manifest                                         | 2 +-
 dev-util/cmake/{cmake-3.13.0_rc3.ebuild => cmake-3.13.0.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)

[Comment 6 Benda Xu 2019-06-26 03:51:43 UTC]

*** Bug 666528 has been marked as a duplicate of this bug. ***