|Summary:||[Future EAPI] Provide the equivalent of EPATCH_EXCLUDE to for eapply|
|Product:||Gentoo Hosted Projects||Reporter:||Anthony Basile <blueness>|
|Severity:||normal||CC:||esigra, kernel, mgorny, toolchain|
|Package list:||Runtime testing required:||---|
|Bug Depends on:|
Description Anthony Basile 2018-04-23 12:53:52 UTC
eapply is not a simple drop in for epatch from epatch.eclass. In particular, there is no equilalent to EPATCH_EXCLUDE. This is useful for some ebuilds where we have large patchsets but would like to exclude one or a few patches. See https://github.com/gentoo/gentoo/pull/8084 Reproducible: Always
Comment 1 Anthony Basile 2018-04-23 12:55:31 UTC
I can also see this as useful for kernel patchsets as well as toolchain patchsets.
Comment 2 Ulrich Müller 2018-04-23 13:05:13 UTC
(In reply to Anthony Basile from comment #0) > eapply is not a simple drop in for epatch from epatch.eclass. Right, and it wasn't meant as one. > In particular, there is no equilalent to EPATCH_EXCLUDE. This is useful for > some ebuilds where we have large patchsets but would like to exclude one or > a few patches. Use epatch if you need its extended features. eapply has been kept simple intentionally, and I don't think that adding epatch's baroque features is the way to go.
Comment 3 Michał Górny 2018-04-23 13:33:54 UTC
If your arguments boil down to 'it is useful', then my counter-argument would boil down to 'you are doing it wrong'. Now, if you want to have a discussion about it, you need to point out examples of why you find it useful, and then I can bring my counter-arguments on how you're doing it wrong.