Bug 653556 – games-emulation/mgba: multiple QA violations

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description David Seifert 2018-04-19 18:38:56 UTC]

The mgba-0.6.3 ebuild has a number of issues that need to be addressed:

1) The DEPEND/RDEPEND specification is wrong. mgba links to libav/ffmpeg, yet specifies virtual/ffmpeg as its libavcodec.so provider. This against the current ffmpeg/libav policy, which requires using USE=libav for dispatching between ffmpeg and libav as stated in

  https://www.gentoo.org/support/news-items/2015-02-01-use-libav.html

This also allows for adding subslot operators both on ffmpeg and libav.


2) When emerging, a number of RPATH security checks in portage are triggered, which is a contravention of Gentoo security policy. Given that the ebuild uses CMake, this can usually be solved using -DCMAKE_SKIP_RPATH=ON

scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-sdl
scanelf: rpath_security_checks(): Security problem NULL DT_RUNPATH in /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-qt
Auto fixing rpaths for /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
Auto fixing rpaths for /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-sdl
Auto fixing rpaths for /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-qt

 * QA Notice: The following files contain insecure RUNPATHs
 *  Please file a bug about this at https://bugs.gentoo.org/
 *  with the maintainer of the package.
 *   /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/lib64/libmgba.so.0.6.1
 *     RPATH: :::::
 *   /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-sdl
 *     RPATH: /var/tmp/portage/games-emulation/mgba-0.6.3/work/mgba-0.6.3_build:
 *   /var/tmp/portage/games-emulation/mgba-0.6.3/image/usr/bin/mgba-qt
 *     RPATH: /var/tmp/portage/games-emulation/mgba-0.6.3/work/mgba-0.6.3_build:


3) -DBUILD_GLES is not used by the build system anymore:

 * One or more CMake variables were not used by the project:
 *   BUILD_GLES

[Comment 1 Larry the Git Cow 2018-04-19 19:29:22 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19342050b6d040d4f5b08aaf2b8d64a9cf7caefc

commit 19342050b6d040d4f5b08aaf2b8d64a9cf7caefc
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2018-04-19 19:28:58 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2018-04-19 19:29:16 +0000

    games-emulation/mgba: Fixed several QA issues
    
    Thanks to Soap for reporting these issues.
    
    Closes: https://bugs.gentoo.org/653556
    Package-Manager: Portage-2.3.31, Repoman-2.3.9

 games-emulation/mgba/mgba-0.6.3.ebuild | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)