Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 653288

Summary: x11-base/xorg-server-1.19.99.904: error: ‘GBM_FORMAT_ARGB2101010’ undeclared (first use in this function); did you mean ‘DRM_FORMAT_ARGB2101010’?
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 649286    
Attachments: x11-base:xorg-server-1.19.99.904:20180416-055717.log.xz

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-04-16 06:01:19 UTC
Created attachment 527562 [details]
x11-base:xorg-server-1.19.99.904:20180416-055717.log.xz

/var/tmp/portage/x11-base/xorg-server-1.19.99.904/work/xorg-server-1.19.99.904/hw/xfree86/drivers/modesetting/drmmode_display.c: In function ‘drmmode_create_bo’:
/var/tmp/portage/x11-base/xorg-server-1.19.99.904/work/xorg-server-1.19.99.904/hw/xfree86/drivers/modesetting/drmmode_display.c:1004:18: error: ‘GBM_FORMAT_ARGB2101010’ undeclared (first use in this function); did you mean ‘DRM_FORMAT_ARGB2101010’?
         format = GBM_FORMAT_ARGB2101010;
                  ^~~~~~~~~~~~~~~~~~~~~~
                  DRM_FORMAT_ARGB2101010
/var/tmp/portage/x11-base/xorg-server-1.19.99.904/work/xorg-server-1.19.99.904/hw/xfree86/drivers/modesetting/drmmode_display.c:1004:18: note: each undeclared identifier is reported only once for each function it appears in
/var/tmp/portage/x11-base/xorg-server-1.19.99.904/work/xorg-server-1.19.99.904/hw/xfree86/drivers/modesetting/drmmode_display.c:1006:18: error: ‘GBM_FORMAT_ARGB8888’ undeclared (first use in this function); did you mean ‘DRM_FORMAT_ARGB8888’?
         format = GBM_FORMAT_ARGB8888;
                  ^~~~~~~~~~~~~~~~~~~
                  DRM_FORMAT_ARGB8888
/var/tmp/portage/x11-base/xorg-server-1.19.99.904/work/xorg-server-1.19.99.904/hw/xfree86/drivers/modesetting/drmmode_display.c:1001:14: warning: variable ‘format’ set but not used [-Wunused-but-set-variable]
     uint32_t format;
              ^~~~~~
gmake[5]: *** [Makefile:741: drmmode_display.lo] Error 1
Comment 1 Matt Turner gentoo-dev 2018-04-16 06:24:09 UTC
I can reproduce. Building with USE=-glamor is enough to trigger it.
Comment 2 Matt Turner gentoo-dev 2018-04-16 06:38:32 UTC
Sent a patch upstream to fix this. Unfortunately after that's fixed, Xwayland fails to link if glamor is disabled. Evidently not a common case.
Comment 3 Larry the Git Cow gentoo-dev 2018-04-17 01:35:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4abddc5e499eef7cdb177e4b8c98219284c376e4

commit 4abddc5e499eef7cdb177e4b8c98219284c376e4
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2018-04-17 01:35:22 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2018-04-17 01:35:37 +0000

    x11-base/xorg-server: Cherry-pick two patches from upstream
    
    Closes: https://bugs.gentoo.org/653288
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 ...-Move-GBM-code-inside-ifdef-GLAMOR_HAS_GB.patch |  48 ++++++
 ....99.904-xwayland-Fix-build-without-glamor.patch | 175 +++++++++++++++++++++
 .../xorg-server/xorg-server-1.19.99.904.ebuild     |   7 +-
 3 files changed, 227 insertions(+), 3 deletions(-)
Comment 4 Matt Turner gentoo-dev 2018-04-17 01:36:41 UTC
Another patch was committed to fix the second bug I mentioned. I've cherry-picked those two patches from upstream back to 1.19.99.904 for your testing pleasure.