| Summary: | app-emacs/vm-8.2.0_beta with app-editors/emacs-26.1_rc1 - Variable name missing after &optional in vm-pcrisis.el | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | milan hodoscek <milan> |
| Component: | Current packages | Assignee: | GNU Emacs project <gnu-emacs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | UPSTREAM |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://launchpad.net/bugs/1763377 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
fix vm-pcrisis.el for emacs-26 elisp
build.log |
||
Created attachment 527128 [details, diff]
fix vm-pcrisis.el for emacs-26 elisp
ading epatch_user to ebuild and put this file in /etc/portage/patches/app-emacs/vm-8.2.0_beta enables vm package to compile with emacs-26
Found this in the /usr/share/emacs/26.1/etc/NEWS
** Using '&rest' or '&optional' incorrectly is now an error.
For example giving '&optional' without a following variable, or
passing '&optional' multiple times:
(defun foo (&optional &rest x))
(defun bar (&optional &optional x))
Previously, Emacs would just ignore the extra keyword, or give
incorrect results in certain cases.
Please attach the entire build log to this bug report. Created attachment 527138 [details]
build.log
Attaching the build log. It fails only if bbdb use flag is used. Without bbdb the vm-pcrisis.el is not compiled (patched out from Makefile)
Since the issue is neither fixed in 8.2.x nor in trunk, can you please report it upstream, too: <https://launchpad.net/vm> (In reply to Ulrich Müller from comment #5) > Since the issue is neither fixed in 8.2.x nor in trunk, can you please > report it upstream, too: <https://launchpad.net/vm> I wanted to look at the louncpad bug reports but it was asking for login, etc, so I got discouraged. But now that you are asking for it I just did it. Sorry for the delay. I wonder about this change in your patch: -(defun vmpc-tab-header-or-tab-stop (&optional backward) +(defun vmpc-tab-header-or-tab-stop (&rest backward) backward is a simple flag there (can be nil or non-nil), so &optional looks right to me. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5e3ee0a508a71cbc4090d86e09e3a5c124566034 commit 5e3ee0a508a71cbc4090d86e09e3a5c124566034 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2018-08-10 06:22:02 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2018-08-10 06:22:41 +0000 app-emacs/vm: Fix function definition in vm-pcrisis.el. Bug: https://bugs.gentoo.org/652952 Package-Manager: Portage-2.3.45, Repoman-2.3.10 app-emacs/vm/files/vm-8.2.0_beta-optional-args.patch | 13 +++++++++++++ .../{vm-8.2.0_beta.ebuild => vm-8.2.0_beta-r1.ebuild} | 18 +++++++++--------- 2 files changed, 22 insertions(+), 9 deletions(-) |
app-emacs/vm-8.2.0_beta doesn't compile with emacs-26.1_rc1. It appears that new elisp is more picky about the syntax. fix provided. I couldn't find anything upstream. this is my emerge --info vm Portage 2.3.28 (python 2.7.14-final-0, default/linux/amd64/17.0/systemd, gcc-7.2.0, glibc-2.26-r5, 4.14.13-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.14.13-gentoo-x86_64-Intel-R-_Xeon-R-_CPU_E5410_@_2.33GHz-with-gentoo-2.4.1 KiB Mem: 8167344 total, 1085988 free KiB Swap: 58975228 total, 58945172 free Timestamp of repository gentoo: Wed, 11 Apr 2018 04:30:01 +0000 Head commit of repository gentoo: 7d1def6e6a798e31da22848448f56c25685edffa sh bash 4.4_p12 ld GNU ld (Gentoo 2.30 p1) 2.30.0 app-shells/bash: 4.4_p12::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.26.1-r1::gentoo dev-lang/python: 2.7.14-r1::gentoo, 3.5.4-r1::gentoo, 3.6.4::gentoo dev-util/cmake: 3.11.0::gentoo dev-util/pkgconfig: 0.29.2::gentoo sys-apps/baselayout: 2.4.1-r2::gentoo sys-apps/openrc: 0.34.11::gentoo sys-apps/sandbox: 2.12::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69-r4::gentoo sys-devel/automake: 1.15.1-r1::gentoo sys-devel/binutils: 2.29.1-r1::gentoo, 2.30::gentoo sys-devel/gcc: 7.2.0-r1::gentoo sys-devel/gcc-config: 1.9.1::gentoo sys-devel/libtool: 2.4.6-r4::gentoo sys-devel/make: 4.2.1-r1::gentoo sys-kernel/linux-headers: 4.14::gentoo (virtual/os-headers) sys-libs/glibc: 2.26-r5::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-metamanifest: yes sync-rsync-extra-opts: sync-rsync-verify-max-age: 24 x-portage location: /usr/local/portage masters: gentoo priority: 0 science location: /var/lib/layman/science masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=core2" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /etc/stunnel/stunnel.conf /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/hsqldb" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.2/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -march=core2" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs candy config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -march=core2" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="en_US.utf8" LC_ALL="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LINGUAS="en sl" MAKEOPTS="-j8" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="64bit X a52 aac aalib accessibility acl acpi alsa amarok amd64 amr amrnb amrwb ansi apache2 apng apparmor applet asf asn audio audiofile audit avcodec avformat bash-completion bbdb berkdb bitmapfonts bittorrent bonobo bookmarks branding bzip2 cairo canna cjk clang classic cli clozurecl clucene community compat context corefonts cracklib cramfs crypt cryptsetup css ctype cups curl cxx daap dbus declarative deprecated detex device-mapper dga dhclient dirac dkim dri dv dvdarchive dvdnav dvdr dvdread dvi dvi2tty elfutils emacs emf emovix enca encode eselect evdev exceptions exif extensions extra extras f77 faac faad fam fastcgi ffmpeg fileinfo filter flac fltk fontconfig foomaticdb fortran fts3 g3dvl gallium gcj gcrypt gd gdbm gdu gecko geoip geoloc gif gimp gimpprint git gkrellm glamor glib gmp gnuplot gphoto2 gpl graphics graphite gsf gsl gtk gtk3 gudev gui gzip h323 handbook hash hdf hdf5 holidays hpn http hunspell hwdb icedtea7 iconv icu imagemagick inmemory introspection ipc ipod iptables ipv6 java javascript jbig jit jpeg jpeg2k json kdrive keymap kpathsea lame largefile latex latex3 lcms ldap legacy-systray libev libkms libnotify llvm lua luatex lvm1 lzma mad mail matplotlib matroska mbox mdev mdnsresponder-compat miner-fs minizip mjpeg mng mod modemmanager modplug modules mozilla mp3 mp3tunes mp4 mp4live mpd mpeg mpeg2 mpi mplayer mudflap multilib multiuser musepack musicbrainz mysql nautilus ncurses nepomuk net netpbm network nfs nfsv3 nfsv4 nls nptl nsplugin nss offensive ogg ogg123 oggvorbis ogm openbabel openmp openrc orc osdmenu otr pam pango pcf pch pcre pcre16 pdf pdo perl phar pipe pipechan player png policykit posix postproc ppds preview-latex printsupport proxy ps psf pstricks publishers pulseaudio python python3 qt5 quicktime raptor raster readline recursion-limit regex rle romio rtc sasl schroedinger science script scripttools sdl seccomp secure-delete semantic-desktop server session sftp shared-glapi simplexml sip smp sndfile sockets socks5 sox spamassassin speech speex spell sql sqlite sqlite3 ssh ssl startup-notification static-libs stun subversion suexec svg swscale systemd szip tagwriting tcl tcltk tcpd telepathy tetex tex tga theora threads threadsafe tiff tk tokenizer toolame tremor truetype twolame udev unicode unzip urandom usb utils uuid v4l v4l2 vala vapigen vhook vhosts video video-file vim vim-pager virtuoso vorbis vorbis-psy vpx wav weather webdav webdav-neon webgl widgets win32 win64 wmf wxgtk1 x264 xattr xcb xetex xinerama xkb xml xmlreader xmlwriter xmp xorg xpdf-headers xpm xscreensaver xtended xulrunner xv xvfb xvid xvmc yv12 zip zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="actions alias auth_basic auth_digest authn_anon authn_dbd authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock dbd deflate dir disk_cache env expires ext_filter file_cache filter headers ident imagemap include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif so speling status unique_id userdir usertrack vhost_alias authn_core authz_core unixd socache_shmcb cgi lbmethod_byrequests slotmem_shm" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="all" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" CURL_SSL="nss" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python3_6 python2_7" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="radeon radeonhd ati" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, ENV_UNSET, INSTALL_MASK, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= app-emacs/vm-8.2.0_beta::gentoo was built with the following: USE="bbdb ssl" ABI_X86="(64)"