Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 652580

Summary: sci-chemistry/molsketch-0.6.0 version bump
Product: Gentoo Linux Reporter: Viktor Yu. Kovalskii <vityokster>
Component: Current packagesAssignee: Gentoo Chemistry-Related Packages <sci-chemistry>
Status: RESOLVED FIXED    
Severity: normal CC: gentoo_bugs.nu_q5v, jstein, kredba, xpistianbecker2
Priority: Normal Keywords: EBUILD, PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=836644
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: sci-chemistry/molsketch-0.5.1.ebuild
molsketch-0.5.1-more-quotes.patch
sci-chemistry/molsketch-0.6.0
molsketch-0.6.0-more-quotes.patch
sci-chemistry/molsketch-0.7.0.ebuild

Description Viktor Yu. Kovalskii 2018-04-05 09:18:10 UTC
Created attachment 526594 [details]
sci-chemistry/molsketch-0.5.1.ebuild

sci-chemistry/molsketch-0.5.1 was released 2018-01-21:

Version 0.5.1 Boron-10

    Newman radius of atom to draw Newman-type projections
    New tools for aligning, spacing, and cleaning up molecules
    Better encapsulate calls to OpenBabel to avoid crashes
    Several fixes to qmake/cmake installation of files (including MIME types)

Version Boron 0.5.0

    change log displayed on startup
    lone pairs and radical electrons
    selection by type (not yet really useful as properties are usually edited only for single items)
    querying Wikidata for chemical structures (requires OpenBabel and InChI support)
    new packaging of Windows libraries (mainly OpenBabel)
Comment 1 Viktor Yu. Kovalskii 2018-04-05 09:19:36 UTC
Created attachment 526596 [details, diff]
molsketch-0.5.1-more-quotes.patch

molsketch-0.5.1-more-quotes.patch is slight modified from molsketch-0.4.1-more-quotes.patch
Comment 2 Viktor Yu. Kovalskii 2018-04-05 09:20:59 UTC
At ebuild I remove two lines from ebuild for 0.4.1 version because of

 * One or more CMake variables were not used by the project:
 *   CMAKE_DISABLE_FIND_PACKAGE_KDE4
 *   ENABLE_TESTS
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2019-10-19 05:58:30 UTC
*** Bug 698000 has been marked as a duplicate of this bug. ***
Comment 4 J.Borme 2020-05-04 14:47:13 UTC
Created attachment 635980 [details]
sci-chemistry/molsketch-0.6.0

Here is the ebuild for 0.6.0. Differences with the 0.5.1 submitted above: SRC_URI, and the two lines removed above by Viktor Yu. Kovalskii are here kept because I did not get the "unused" message (but maybe they should be removed).
Comment 5 J.Borme 2020-05-04 14:48:01 UTC
Created attachment 635982 [details, diff]
molsketch-0.6.0-more-quotes.patch

to be included in files/ directory
Comment 6 J.Borme 2021-01-02 16:32:56 UTC
Created attachment 680704 [details]
sci-chemistry/molsketch-0.7.0.ebuild

As compared to 0.6.0, molsketch-0.7.0 does not need the "quotes" patch (upstreamed). As compared to 0.4.1-r1, CMakeLists.txt has changed directory.
Comment 7 J.Borme 2021-01-02 16:35:34 UTC
(In reply to Jérôme Borme from comment #6)

 --- molsketch_old/molsketch-0.4.1-r1.ebuild	2020-05-21 00:39:07.000000000 +0100
+++ molsketch/molsketch-0.7.0.ebuild	2021-01-02 16:23:32.352567226 +0000
@@ -28,12 +28,11 @@
 
 PATCHES=(
 	"${FILESDIR}"/${PN}-0.3.0-_DEFAULT_SOURCE.patch
-	"${FILESDIR}"/${P}-more-quotes.patch
 )
 
 src_prepare() {
 	sed -e "/LIBRARY DESTINATION/ s/lib/$(get_libdir)/g" \
-		-i {obabeliface,libmolsketch/src}/CMakeLists.txt || die #351246
+		-i {obabeliface,libmolsketch}/CMakeLists.txt || die #351246
 	cmake_src_prepare
 }
Comment 8 David Kredba 2021-03-20 16:57:27 UTC
Version 0.7.1 needs an upstream fix in the generateTranslations.cmake file, https://github.com/hvennekate/Molsketch/commit/e1f28e44a3f8e4eff2664beed27be691d2641e74?branch=e1f28e44a3f8e4eff2664beed27be691d2641e74&diff=unified

- qt5_create_translation(qmFileList ${translationFiles})
+ qt_add_translation(qmFileList ${translationFiles})

And modified ebuild installs docs to /usr/usr/share/doc... and libraries goes to /usr/lib64/molsketch folder, dosym does not work, the binary is named molsketch directly.
But in general it works if fixed between the install and merge phases.
Comment 9 Larry the Git Cow gentoo-dev 2022-02-24 15:12:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83a73d4ebca119b5aa122d856f677aaec9390d06

commit 83a73d4ebca119b5aa122d856f677aaec9390d06
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-02-24 15:12:15 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-02-24 15:12:22 +0000

    sci-chemistry/molsketch: add version 0.7.2
    
    Closes: https://bugs.gentoo.org/652580
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 sci-chemistry/molsketch/Manifest               |  1 +
 sci-chemistry/molsketch/molsketch-0.7.2.ebuild | 37 ++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)