Bug 652424

Summary:	sys-apps/systemd should check CONFIG_FW_LOADER_USER_HELPER
Product:	Gentoo Linux	Reporter:	Viktor Levin <viklevin2>
Component:	Current packages	Assignee:	Gentoo systemd Team <systemd>
Status:	RESOLVED WONTFIX
Severity:	normal	CC:	viklevin2
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Viktor Levin 2018-04-04 14:44:14 UTC

sys-apps/systemd ebuild does not check CONFIG_FW_LOADER_USER_HELPER

But it should:

https://github.com/systemd/systemd/blob/master/README

>         Userspace firmware loading is not supported and should
>         be disabled in the kernel:
> CONFIG_FW_LOADER_USER_HELPER=n

Probably it should check
FW_LOADER_USER_HELPER instead of FW_LOADER_USER_HELPER_FALLBACK.

Comment 1 Viktor Levin 2018-09-04 20:22:05 UTC

Please confirm.

Comment 2 Larry the Git Cow gentoo-dev

2020-02-23 17:43:31 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=475b795a941922c80fe24685765596a1cfed8aa4

commit 475b795a941922c80fe24685765596a1cfed8aa4
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-02-23 17:43:04 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-02-23 17:43:28 +0000

    sys-apps/systemd: drop FW_LOADER_USER_HELPER_FALLBACK kernel check
    
    This isn't supported by systemd-udevd, but users might provide some
    other userspace helper program to satisfy this.
    
    Bug: https://bugs.gentoo.org/652424
    Package-Manager: Portage-2.3.89_p9, Repoman-2.3.20_p79
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/systemd/systemd-244.3.ebuild      | 2 +-
 sys-apps/systemd/systemd-245_rc1-r2.ebuild | 2 +-
 sys-apps/systemd/systemd-9999.ebuild       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)