Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 651646

Summary: net-analyzer/smokeping-2.7.3 files/smokeping.init.5 rrd dump and xml restore not working
Product: Gentoo Linux Reporter: nic <nic>
Component: Current packagesAssignee: Netmon Herd <netmon>
Status: UNCONFIRMED ---    
Severity: normal CC: mjo
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=651212
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 631140    
Attachments: smokeping-init

Description nic 2018-03-26 20:19:28 UTC
The smokeping.init.5 file with unstable net-analyzer/smokeping-2.7.1 incorrectly has the extra commands "dump" and "restore" in the started command list. Both sub commands also incorrectly reference ${myservice} in checking if we are running.




Please split these commands out:

 extra_started_commands="reload"
 extra_stopped_commands="dump restore"


And remove the 'if service_started' checks from the dump and restore functions (changing to RC_SVCNAME doesn't make sense here for these commands should only execute when smokeping is not writing to the rrd files)

Thanks ;)
Comment 1 nic 2018-04-02 21:59:56 UTC
Created attachment 526378 [details]
smokeping-init

This also restores the logging issue in Bug #651212
Comment 2 nic 2018-04-02 22:10:34 UTC
Clarification; This has actually been an issue with the init script for a while, not just the latest file as originally noted.
smokeping.init.3 dated May 2016 also has the issue in checking the non-existent variable $myservice


These extra commands are very convenient when migrating RRD files between architectures (ie i686 to x86_64).