Bug 651598

Summary:	app-emulation/libvirt - /etc/init.d/libvirt-guests: fix Xen host support
Product:	Gentoo Linux	Reporter:	Karl Hakimian <hyedad>
Component:	Current packages	Assignee:	Matthias Maier <tamiko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	virtualization
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	This patch removed dom0 from host list to allow things to progress

Description Karl Hakimian 2018-03-26 15:14:59 UTC

When libvirt-guests tries to shutdown or suspend xen guests, it is unable to tell when all of the guests have terminated and ends up waiting the entire timeout before going on. This is because in xen, dom0 is always running. Simply grepping out the dom0 uuid (all 0s) should take care of this issue.

Reproducible: Always

Steps to Reproduce:
1.shutdown libvirt-guests with xen hosts
2.wait for libvirt-guests to finish

Actual Results:  
It finishes after timeout time has passed since it can't detect that all guests have terminated.

Expected Results:  
Continue on after all guests have terminated

Comment 1 Karl Hakimian 2018-03-26 15:15:54 UTC

Created attachment 525478 [details, diff]
This patch removed dom0 from host list to allow things to progress

Comment 2 Larry the Git Cow gentoo-dev

2018-08-19 19:08:04 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e3f7b40a206e8e014e7820734caa58c4e88c033

commit 3e3f7b40a206e8e014e7820734caa58c4e88c033
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-08-19 19:06:45 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-08-19 19:07:38 +0000

    app-emulation/libvirt: update libvirt-guests.init openrc script
    
    From the bug report:
    
      """
      When libvirt-guests tries to shutdown or suspend xen guests, it is
      unable to tell when all of the guests have terminated and ends up
      waiting the entire timeout before going on. This is because in xen,
      dom0 is always running. Simply grepping out the dom0 uuid (all 0s)
      should take care of this issue.
      """
    
    Thanks to Karl Hakimian for bug report and patch.
    
    This is fixed in versions 4.6.0-r1 and 9999.
    
    Closes: https://bugs.gentoo.org/651598
    Package-Manager: Portage-2.3.47, Repoman-2.3.10

 app-emulation/libvirt/files/libvirt-guests.init-r3 | 236 +++++++++++++++++++++
 ...ibvirt-4.6.0.ebuild => libvirt-4.6.0-r1.ebuild} |   2 +-
 app-emulation/libvirt/libvirt-9999.ebuild          |   2 +-
 3 files changed, 238 insertions(+), 2 deletions(-)