| Summary: | games-board/gmchess-0.29.6-r2 : cchess.cpp:693:18: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Gentoo Games <games> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | theonesleepymario |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/19390 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 700696 | ||
| Bug Blocks: | |||
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 games-board:gmchess-0.29.6-r2:20180325-052620.log logs.tbz2 temp.tbz2 gmchess-0.29.6-pointer-to-int.patch gmchess-0.29.6-pointer-to-int.patch |
||
Created attachment 525334 [details]
emerge-info.txt
Created attachment 525336 [details]
emerge-history.txt
Created attachment 525338 [details]
environment
Created attachment 525340 [details]
etc.portage.tbz2
Created attachment 525342 [details]
games-board:gmchess-0.29.6-r2:20180325-052620.log
Created attachment 525344 [details]
logs.tbz2
Created attachment 525346 [details]
temp.tbz2
The same exact error on my machine, on amd64 with gcc-7.3.0-r3 Created attachment 554510 [details, diff]
gmchess-0.29.6-pointer-to-int.patch
Thanks to gcc-7, some "typos" are detected. This copy loop end condition was a bit odd.
This patch fixes the issue.
Created attachment 596764 [details, diff]
gmchess-0.29.6-pointer-to-int.patch
Previous patch was wrong
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7f141b7174e0fb1730d994e12f804da50c68103 commit e7f141b7174e0fb1730d994e12f804da50c68103 Author: Sergey Torokhov <torokhov-s-a@yandex.ru> AuthorDate: 2021-02-09 19:40:51 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2021-02-13 13:23:47 +0000 games-board/gmchess: fix build error and segfaults The applied patch fixes build error issue and some additional issues that cause segmentation fault on run (for more detailes see the second issue description in the list below). Thanks to Samuel Bauer for proposed patch. Closes: https://bugs.gentoo.org/651408 Closes: https://bugs.gentoo.org/700696 Signed-off-by: Sergey Torokhov <torokhov-s-a@yandex.ru> Closes: https://github.com/gentoo/gentoo/pull/19390 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../files/gmchess-0.29.6_fix_build_segfault.patch | 102 +++++++++++++++++++++ games-board/gmchess/gmchess-0.29.6-r3.ebuild | 59 ++++++++++++ 2 files changed, 161 insertions(+) |
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -O2 -pipe -march=native -std=c++11 -c -o convert_pgn-cchess.o `test -f 'cchess.cpp' || echo './'`cchess.cpp cchess.cpp: In function ‘void FenMirror(char*, const char*)’: cchess.cpp:693:18: error: ISO C++ forbids comparison between pointer and integer [-fpermissive] while(lpSrc != '\0' && lpDst < lpDstLimit) { ^~~~ ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.0-developer_20180319-191208 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-7.3.0 * Available Python interpreters, in order of preference: [1] python3.5 [2] python3.6 (fallback) [3] python2.7 (fallback) [4] pypy3 (fallback) java-config: The following VMs are available for generation-2: *) IcedTea JDK 3.7.0 [icedtea-bin-8] Available Java Virtual Machines: [1] icedtea-bin-8 system-vm emerge -qpv games-board/gmchess [ebuild N ] games-board/gmchess-0.29.6-r2