Bug 651296

Summary:	app-emulation/libvirt-4.1.0-r2: multiple QA issues; bash completions, bashisms, empty directories
Product:	Gentoo Linux	Reporter:	Michał Górny <mgorny>
Component:	Current packages	Assignee:	Matthias Maier <tamiko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	virtualization
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	app-emulation:libvirt-4.1.0-r2:20180323-222344.log.gz

Description Michał Górny archtester

2018-03-23 22:45:11 UTC

* Messages for package app-emulation/libvirt-4.1.0-r2:
 * Log file: /var/log/portage/app-emulation:libvirt-4.1.0-r2:20180323-222344.log

 *   CONFIG_MEMCG_SWAP:	 is not set when it should be.
 * Please check to make sure these options are set correctly.
 * Failure to do so may cause unexpected problems.
 * Problems with installed bash completions were found:
 * 
 * 	vsh: incorrect name, no completions for 'vsh' command defined.
 * 
 * For more details on installing bash-completions, please see:
 * https://wiki.gentoo.org/wiki/Bash/Installing_completion_files
 * 
 * QA Notice: shell script appears to use non-POSIX feature(s):
 *    possible bashism in /etc/init.d/libvirt-guests line 123 (echo -n):
 *    		echo -n "."
 * One or more empty directories installed to /var:
 * 
 *   /var/lib
 *   /var/lib/libvirt
 *   /var/lib/libvirt/boot
 *   /var/lib/libvirt/filesystems
 *   /var/lib/libvirt/images
 *   /var/lib/libvirt/lockd
 *   /var/lib/libvirt/lockd/files
 *   /var/lib/libvirt/qemu
 * 
 * If those directories need to be preserved, please make sure to create
 * or mark them for keeping using 'keepdir'. Future versions of Portage
 * will strip empty directories from installation image.

Comment 1 Michał Górny archtester

2018-03-23 22:48:22 UTC

Created attachment 525148 [details]
app-emulation:libvirt-4.1.0-r2:20180323-222344.log.gz

Comment 2 Larry the Git Cow gentoo-dev

2018-03-24 02:25:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=437ef2f8ef6acf820989ad44902d1838c679729d

commit 437ef2f8ef6acf820989ad44902d1838c679729d
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2018-03-24 02:24:42 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2018-03-24 02:25:34 +0000

    app-emulation/libvirt: address QA messages
    
     * use printf instead of echo -n
     * remove dyanmically created directories
    
    Closes: https://bugs.gentoo.org/651296
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-emulation/libvirt/files/libvirt-guests.init-r2                    | 2 +-
 .../libvirt/{libvirt-4.1.0-r2.ebuild => libvirt-4.1.0-r3.ebuild}      | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)