Bug 651112

Summary:	sys-cluster/ganglia-web-3.5.10-r1 - Broken instructions with php 7
Product:	Gentoo Linux	Reporter:	Brian Evans (RETIRED) <grknight>
Component:	Current packages	Assignee:	Daniel M. Weeks <dan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cluster, proxy-maint
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	651094

Description Brian Evans (RETIRED) gentoo-dev

2018-03-21 19:17:51 UTC

A cursory scan of this package shows broken code with modern PHP.

Please update this code as PHP 5.6, the last branch to support this, will be EOL at the end of 2018 and likely removed shortly after.

Run-time error found:

File: /var/tmp/portage/sys-cluster/ganglia-web-3.5.10-r1/work/ganglia-web-3.5.10/api/host.php
> Line 57: [Error] Removed function "split" called
    split('/', $v);


Run-time behavior differences found:

File: /var/tmp/portage/sys-cluster/ganglia-web-3.5.10-r1/work/ganglia-web-3.5.10/lib/Services/JSON.php
> Line 142: [Error] PHP 4 constructors are now deprecated
    function Services_JSON($use = 0)
    {
    }
> Line 912: [Error] PHP 4 constructors are now deprecated
    function Services_JSON_Error($message = 'unknown error', $code = null, $mode = null, $options = null, $userinfo = null)
    {
    }
> Line 926: [Error] PHP 4 constructors are now deprecated
    function Services_JSON_Error($message = 'unknown error', $code = null, $mode = null, $options = null, $userinfo = null)
    {
    }

Comment 1 Brian Evans (RETIRED) gentoo-dev

2019-01-23 18:18:20 UTC

Is this still relevant?

Comment 2 Brian Evans (RETIRED) gentoo-dev

2019-01-23 21:20:10 UTC

Looking over the repository:

It seems as if the split was corrected.

Services_JSON is only included if native support does not exist.

Please ensure the json USE of php is enabled as a dependency such that you do not hit errors with Services_JSON.  Then you may close this bug.

Comment 3 Larry the Git Cow gentoo-dev

2019-05-31 13:46:51 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6aebfb80ef1627de6de79684005b9f8fa4fee36c

commit 6aebfb80ef1627de6de79684005b9f8fa4fee36c
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2019-05-31 13:46:20 +0000
Commit:     Brian Evans <grknight@gentoo.org>
CommitDate: 2019-05-31 13:46:20 +0000

    sys-cluster/ganglia-web: Fix dependencies to ensure json on PHP
    
    Non-maintainer commit. Necessary for PHP 7 compatibility
    
    Closes: https://bugs.gentoo.org/651112
    Package-Manager: Portage-2.3.67, Repoman-2.3.13
    Signed-off-by: Brian Evans <grknight@gentoo.org>

 .../{ganglia-web-3.7.3.ebuild => ganglia-web-3.7.3-r1.ebuild}         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)