Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 651080

Summary: net-fs/nfs-utils-2.3.1-r3 fails to build on musl with issue about res_querydomain
Product: Gentoo Linux Reporter: Robert Bridge <robert>
Component: Current packagesAssignee: Gentoo musl team <musl>
Status: RESOLVED FIXED    
Severity: normal CC: base-system, gentoo, polynomial-c
Priority: Normal Keywords: NeedPatch
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build log
config.log
emerge --info output
emerge -pqv output
Patch from Alpine
limits.patch

Description Robert Bridge 2018-03-21 15:16:45 UTC
Created attachment 524650 [details]
build log

When attempting to build net-fs/nfs-utils-2.3.1-r3 on musl, I am getting configure failures with the following error:
checking for __res_querydomain in -lresolv... no
configure: error: res_querydomain needed

This would appear to be due to a glibc-ism in the nfs-utils configure.ac on line 404.
Comment 1 Robert Bridge 2018-03-21 15:17:10 UTC
Created attachment 524652 [details]
config.log
Comment 2 Robert Bridge 2018-03-21 15:17:31 UTC
Created attachment 524654 [details]
emerge --info output
Comment 3 Robert Bridge 2018-03-21 15:17:48 UTC
Created attachment 524656 [details]
emerge -pqv output
Comment 4 Felix Janda 2018-03-22 15:35:44 UTC
Created attachment 524790 [details, diff]
Patch from Alpine

This patch from Alpine Linux should fix this issue.

It would be nice to get it upstream.
Comment 5 Robert Bridge 2018-03-22 20:03:07 UTC
Created attachment 524932 [details, diff]
limits.patch

My testing indicates we need more than that one patch.

Just to get it to build we also need the limits patch, attached, as well. I am assuming this is for something that on glibc is picked up as an indirect dependency when it's actually a direct dependency.
Comment 6 Robert Bridge 2018-03-22 20:03:33 UTC
Oh, and that limits.patch is also lifted from Alpine as well.
Comment 7 Robert Bridge 2018-03-23 12:23:25 UTC
I have just tested the res_querydomain patch on glibc, and it causes the configure phase to break.

Not sure what the correct "both libcs" fix is here.
Comment 9 Larry the Git Cow gentoo-dev 2019-04-20 17:35:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a98ed1ed020ce63dd299629d7d4a7827c2cdeef

commit 7a98ed1ed020ce63dd299629d7d4a7827c2cdeef
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-04-20 17:34:52 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-04-20 17:35:17 +0000

    net-fs/nfs-utils: Fixed build on musl
    
    Closes: https://bugs.gentoo.org/651080
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 ...-2.3.4_rc2-improved_res_querydomain_check.patch | 41 ++++++++++++++++++++++
 net-fs/nfs-utils/nfs-utils-2.3.3.ebuild            |  1 +
 2 files changed, 42 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2019-04-20 18:34:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bac589455e4c1d815a27cbe41bd2171698a65d0

commit 3bac589455e4c1d815a27cbe41bd2171698a65d0
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-04-20 18:33:40 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-04-20 18:34:30 +0000

    net-fs/nfs-utils: Added another musl build fix.
    
    Closes: https://bugs.gentoo.org/651080
    Package-Manager: Portage-2.3.64, Repoman-2.3.12
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../nfs-utils/files/nfs-utils-2.3.1-limits.patch   | 105 +++++++++++++++++++++
 net-fs/nfs-utils/nfs-utils-2.3.3.ebuild            |   1 +
 2 files changed, 106 insertions(+)
Comment 11 Michael 'veremitz' Everitt 2019-04-21 02:27:45 UTC
Limits patch occurs upstream in http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=dce8f980e25cf625d1bce2ef6f499b3a2664f2ce .

Watch this space for v2.3.4 :]
Comment 12 Michael 'veremitz' Everitt 2019-04-21 11:21:48 UTC
Segfault on freeaddrinfo better solved with adelie patch at https://code.foxkit.us/adelie/packages/commit/8c98c47f9b147a77bfca7cc75b97cc0e98e4551e than the upstream one, also under musl.

(upstream solution is: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=ed06fade6dc46df0a38caab2e465dfaabfc76f46 for comparison, but noted to take additional branches)