Bug 650886

Summary:	app-emulation/libvirt-4.1.0 USE=apparmor - make[2]: *** No rule to make target 'apparmor/usr.libexec.virt-aa-helper', needed by 'all-am'. Stop.
Product:	Gentoo Linux	Reporter:	Peter Joanes <pjoanes>
Component:	Current packages	Assignee:	Matthias Maier <tamiko>
Status:	RESOLVED INVALID
Severity:	normal	CC:	virtualization
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Peter Joanes 2018-03-19 14:47:34 UTC

Installing libvirt-4.1.0 fails with:
make[2]: *** No rule to make target 'apparmor/usr.libexec.virt-aa-helper', needed by 'all-am'.  Stop.

This is because the patch /usr/portage/app-emulation/libvirt/files/libvirt-3.10.0-r2-fix_paths_for_apparmor.patch renames references to usr.lib.libvirt.virt-aa-helper as usr.libexec.virt-aa-helper but the file isn't renamed.

The emerge can be successfully completed with ebuild after renaming the file with:
cd /var/tmp/portage/app-emulation/libvirt-4.1.0/work/libvirt-4.1.0/examples/apparmor && mv usr.lib.libvirt.virt-aa-helper usr.libexec.virt-aa-helper

Comment 1 aporilel 2018-03-19 15:11:46 UTC

the file is renamed in libvirt-3.10.0-r2-fix_paths_for_apparmor.patch

>diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper b/examples/apparmor/usr.libexec.virt-aa-helper
>similarity index 92%
>rename from examples/apparmor/usr.lib.libvirt.virt-aa-helper
>rename to examples/apparmor/usr.libexec.virt-aa-helper
>index bd6181d00..4086f140a 100644
>--- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper
>+++ b/examples/apparmor/usr.libexec.virt-aa-helper

Comment 2 Peter Joanes 2018-03-19 23:27:36 UTC

(In reply to aporilel from comment #1)
> the file is renamed in libvirt-3.10.0-r2-fix_paths_for_apparmor.patch
Ah, I didn't notice that but it relies on a more recent `patch` than I had (2.6.1), so perhaps the package should specify >=sys-devel/patch-2.7 which is when support was added for the "diff --git" format.
Thank you!

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2018-03-23 06:34:34 UTC

Please attach the entire build log to this bug report.
Please post your `emerge --info` output in a comment.

Comment 4 Matthias Maier gentoo-dev

2018-03-23 14:22:26 UTC

(In reply to Peter Joanes from comment #2)
> (In reply to aporilel from comment #1)
> > the file is renamed in libvirt-3.10.0-r2-fix_paths_for_apparmor.patch
> Ah, I didn't notice that but it relies on a more recent `patch` than I had
> (2.6.1), so perhaps the package should specify >=sys-devel/patch-2.7 which
> is when support was added for the "diff --git" format.
> Thank you!

sys-devel/patch-2.75 is the lowest version left in tree. I am not sure whether I want to add an explicit build dependency on a patch version that has left the tree already a while ago...