Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 650596

Summary: sci-libs/opencascade-6.9.1-r2 patch for >=vtk-8.1
Product: Gentoo Linux Reporter: Gert Pellin <gert>
Component: Current packagesAssignee: Michael Weber (RETIRED) <xmw>
Status: RESOLVED FIXED    
Severity: normal CC: gert, jstein
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/7470
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: screenshot of failing emerge
Build log
opencascade-6.9.1 patch

Description Gert Pellin 2018-03-15 21:21:44 UTC
Created attachment 524086 [details]
screenshot of failing emerge

From VTK 7.1 the method name InsertNextTupleValue is repplaced by InsertNextTypedTuple.

Opencascade will not compile without this patch.

https://github.com/gentoo/gentoo/pull/7470#issuecomment-373526239
Comment 1 Jonas Stein gentoo-dev 2018-03-27 18:23:41 UTC
Thank you for the report. Please recompile and *attach* the logfiles,
instead of a screenshot
https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Comment 2 Gert Pellin 2018-03-29 21:12:42 UTC
Created attachment 526132 [details]
Build log

error: ‘class vtkIdTypeArray’ has no member named ‘InsertNextTupleValue’; did you mean ‘InsertNextTuple’?
Comment 3 Gert Pellin 2018-03-29 21:21:12 UTC
Created attachment 526134 [details]
opencascade-6.9.1 patch

patch for compiling opencascade with vtk-7.1 and higher
Comment 4 Andreas Sturmlechner gentoo-dev 2018-04-04 23:13:58 UTC
Did you submit that patch upstream or was it picked from upstream?
Comment 5 Gert Pellin 2018-04-05 07:32:31 UTC
hi Andreas, I don't understand your question.
Comment 6 Andreas Sturmlechner gentoo-dev 2018-04-05 12:28:51 UTC
The question was if, if you wrote the patch yourself, did you submit it to upstream so the next version is fixed for >=vtk-8.1? And if you did not write the patch yourself, did you pick it from the upstream code repository? In the latter case there should always be the full commit message included to give credits to the author.
Comment 7 Larry the Git Cow gentoo-dev 2018-04-05 12:31:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34251046e57f6eefc3576839fb1c333c8420a604

commit 34251046e57f6eefc3576839fb1c333c8420a604
Author:     switch87 <gert@pellin.be>
AuthorDate: 2018-03-15 21:05:46 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-04-05 12:24:22 +0000

    sci-libs/opencascade: Fix build with >=vtk-8.1.0
    
    Closes: https://bugs.gentoo.org/650596
    Closes: https://github.com/gentoo/gentoo/pull/7470

 .../files/opencascade-6.9.1-vtk-8.1.patch          | 48 ++++++++++++++++++++++
 sci-libs/opencascade/opencascade-6.9.1-r2.ebuild   |  4 +-
 2 files changed, 50 insertions(+), 2 deletions(-)
Comment 8 Gert Pellin 2018-04-05 13:04:11 UTC
I wrote it myself. I did not submit it to upstream. I will do so.