| Summary: | xfce-base/thunar depend on xfce-extra/tumbler to display thumbnails | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | schmitt953 |
| Component: | Current packages | Assignee: | XFCE Team <xfce> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | joe, jstein |
| Priority: | Normal | Keywords: | EBUILD, PATCH |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | I attached a patched ebuild | ||
I hit this. Had a convo on #gentoo-chat IRC tonight about it. TL;DR: desktop stuff complex, stuff like this expected to happen when cherry-picking desktop apps. My thought was to use thumbnail USE flag by default and depend on tumbler with it. Immediately received pushback because this isn't how Gentoo handles optional runtime deps. Ebuilds usually include optfeature or if it's critical enough for core functionality just hard depend on it. Optfeature doesn't change dependencies, just prints a notice when installing if things are missing. I don't like it since its unlikely users will read it, but I concede it's better than current situation. Second issue is tumbler needs to be built with the filetype support you want to have thumbnails generated for. So needs multiple optfeature (eg. jpg, pdf, ffmpeg for video) Third issue discussed is is a potential privacy concern having local thumbnails stored from any new media added. (think plugging a client's usb drive, tumbler would generate thumbnails and store locally even after the drive is removed). Unfortunately I don't have a better solution other than requesting thunar's upstream add a message saying something around the lines of 'thumbnails not found, install thumbnailer or another thumbnail generation package to display thumbnails'. yes agreed. I have been a part of that conversation and I brought up an example or two for why people would not want thumbnails on, privacy, or a minimalist use case. I have improved the Thunar wiki page for documentation on thumbnailers. https://wiki.gentoo.org/wiki/Thunar#Tumbler Its not correct to say Thunar does not display thumbnails. It does display. What it doesnt do is automatically generate. So yes Tumbler, or another thumbnailer, is needed for that. But its not proper to say its a dependency. Any number of thumbnailer programs can be chosen instead. If we want people to know about this, best bet is to create an optfeature in thunar, to mention tumbler. thunar ebuild should get this inserted into the bottom of pkg_postinst(){ optfeature "thumbnail auto-generation service" 'xfce-extra/tumbler' } Thats my suggestion here, it feels more like a user awareness thing |
Created attachment 524068 [details] I attached a patched ebuild xfce-base/thunar does not pull in xfce-extra/tumbler. Tumbler is required to display thumbnails in thunar. We may want to make it a use flag if this dependency is optional however most people probably want thumbnail support if there is no standard use flag besides may be "png".