| Summary: | sys-cluster/util-vserver-0.30.216_pre3120-r1 : /.../fs.h:366:23: error: expected = , , , ; , asm or _attribute_ before _kernel_rwf_t | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Patrice Clement <monsieurp> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ccx, jstein, sandino, treecleaner, trs |
| Priority: | Normal | Keywords: | PMASKED, PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/11493 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 sys-cluster:util-vserver-0.30.216_pre3120-r1:20180315-030939.log temp.tbz2 Use dietlibc header files ebuild with dietlibc patch dietlibc headers patch for 0.30.216_pre3131 ebuild for 0.30.216_pre3131 Ebuild for 0.30.216_pre3120 with dietlibc and runtime paths patches ebuild for 0.30.216_pre3131 |
||
Created attachment 524046 [details]
emerge-info.txt
Created attachment 524048 [details]
emerge-history.txt
Created attachment 524050 [details]
environment
Created attachment 524052 [details]
etc.portage.tbz2
Created attachment 524054 [details]
logs.tbz2
Created attachment 524056 [details]
sys-cluster:util-vserver-0.30.216_pre3120-r1:20180315-030939.log
Created attachment 524058 [details]
temp.tbz2
This issue is probably not related to gcc itself, but the linux-headers used when compiling util-vserver. At least when compiling util-vserver with linux-headers 4.14 on a vserver kernel 4.9, the problem appears. When installing linux-headers that match the running kernel version, i.e. linux-headers-4.9, the problem goes away on my systems, with both gcc 6.4 and gcc 7.3. Actually, based on this debian bug report, it seems to be a dietlibc shortcoming: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885961 Created attachment 565830 [details, diff]
Use dietlibc header files
This patch replaces the conflicting glibc headers with dietlibc's.
Can you give it a try?
Created attachment 565832 [details]
ebuild with dietlibc patch
This ebuild applies the attached (565830) dietlibc headers patch
Created attachment 565834 [details, diff]
dietlibc headers patch for 0.30.216_pre3131
This patch is for version 0.30.216_pre3131. Include dietlibc headers instead of /usr/include/linux kernel headers.
Created attachment 565836 [details]
ebuild for 0.30.216_pre3131
ebuild for util-vserver 0.30.216_pre3131 with dietlibc headers patch
Please try.
Created attachment 565850 [details] Ebuild for 0.30.216_pre3120 with dietlibc and runtime paths patches Updated ebuild with dietlibc headers patch and fixes for runtime paths in bug 632586 with patch in attachment 565846 [details, diff] Created attachment 565852 [details]
ebuild for 0.30.216_pre3131
Sandino thank you for your contribution. Could you please file a PR on Github instead? Please for the time being include only the patch. We will deal with the version bump later. Thanks! PR #11117 was never merged. I have filed a new PR #11442 with dietlibc patch. (In reply to Sandino Araico Sanchez from comment #17) > PR #11117 was never merged. > I have filed a new PR #11442 with dietlibc patch. PRs must be signed off. You never did. For the record, here's the comment I left on PR#11117: "Thanks @KenjiBrown. You must sign off your contribution for me to merge it." New, clieaner pull request #11493, with the signed-off tag and only one commit. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7b3fe2e4f69b3fc950ecadc3eb10eb91d7a977a1 commit 7b3fe2e4f69b3fc950ecadc3eb10eb91d7a977a1 Author: Sandino Araico Sanchez <sandino@sandino.net> AuthorDate: 2019-03-25 10:12:13 +0000 Commit: Patrice Clement <monsieurp@gentoo.org> CommitDate: 2019-03-25 21:40:50 +0000 sys-cluster/util-vserver: fix dietlibc headers patch. This patch replaces the conflicting glibc headers with dietlibc's. Closes: https://bugs.gentoo.org/650578 Closes: https://github.com/gentoo/gentoo/pull/11493 Signed-off-by: Sandino Araico Sanchez <sandino@sandino.net> Signed-off-by: Patrice Clement <monsieurp@gentoo.org> .../util-vserver-0.30.216_pre3120-dietlibc.patch | 23 ++++++++++++++++++++++ .../util-vserver-0.30.216_pre3120-r1.ebuild | 6 +++--- 2 files changed, 26 insertions(+), 3 deletions(-) |
diet -Os x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I ./lib -I ./ensc_wrappers -D_GNU_SOURCE -D_REENTRANT -DNDEBUG -O2 -pipe -march=native -std=c99 -Wall -pedantic -W -funit-at-a-time -c -o lib_internal/lib_internal_libinternal_diet_a-util-cleanupmount.o `test -f 'lib_internal/util-cleanupmount.c' || echo './'`lib_internal/util-cleanupmount.c In file included from lib_internal/util-cleanupmount.c:25:0: /usr/include/linux/fs.h:366:23: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__kernel_rwf_t’ typedef int __bitwise __kernel_rwf_t; ^~~~~~~~~~~~~~ make[2]: *** [Makefile:7531: lib_internal/lib_internal_libinternal_diet_a-util-cleanupmount.o] Error 1 ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.0-desktop-gnome-systemd_libressl_20180312-192912 ------------------------------------------------------------------- gcc-config -l: [1] x86_64-pc-linux-gnu-7.3.0 * Available Python interpreters, in order of preference: [1] python3.5 [2] python2.7 (fallback) Available Ruby profiles: [1] ruby22 (with Rubygems) [2] ruby23 (with Rubygems) * emerge -qpv sys-cluster/util-vserver [ebuild N ] sys-cluster/util-vserver-0.30.216_pre3120-r1