Summary: | >=app-admin/syslog-ng-3.14.1: keyword request | ||||||
---|---|---|---|---|---|---|---|
Product: | Gentoo Linux | Reporter: | David Flogeras <dflogeras2> | ||||
Component: | Keywording | Assignee: | Tomáš Mózes <hydrapolic> | ||||
Status: | RESOLVED OBSOLETE | ||||||
Severity: | normal | CC: | guido.schmitz, leio, proxy-maint | ||||
Priority: | Normal | Flags: | stable-bot:
sanity-check+
|
||||
Version: | unspecified | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Package list: |
=app-admin/syslog-ng-3.13.2 ~arm
=app-admin/syslog-ng-3.14.1 ~alpha ~arm ~arm64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc
=dev-libs/ivykis-0.42.2 ~alpha ~arm ~arm64 ~hppa ~ia64 ~ppc ~ppc64 ~sparc
=net-libs/rabbitmq-c-0.8.0 ~alpha ~ia64 ~ppc64 ~sparc
|
Runtime testing required: | --- | ||||
Bug Depends on: | |||||||
Bug Blocks: | 646778 | ||||||
Attachments: |
|
Description
David Flogeras
2018-03-14 15:25:03 UTC
Hello, it was done on purpose as there was no interest in maintaining syslog-ng for a long time. Since I don't have any arm machine, I couldn't test it. Can you please test syslog-ng 3.14.1 on arm/arm64? If it works I'm sure we can restore the arm/arm64 keywords. Thank you. That's for arch teams to do (dropping keywords), not you. If you do it, you should be asking re-keywording or re-stabling (and not drop old versions that have them before it's done, if possible) Ok, I've tested =syslog-ng-3.14.1 on the following: aarch64-unknown-linux-gnu (Both on 64bit Raspberry Pi 3, and an espressobin board) armv7a-unknown-linux-gnueabi (cubieboard 2) armv6j-unknown-linux-gnueabihf (Rpi) armv6j-unknown-linux-musleabihf (Rpi) ** see below armv6j-unknwon-linux-uclibceabihf (Rpi) All compiled/worked. Note I also had to keyword =dev-libs/ivykis-0.42.2 On musl I required a one line patch (I'll attach). A non-standard include file was introduced in the 3.14.1 release, and has subsequently been removed upstream (for BSD compat also) https://github.com/balabit/syslog-ng/issues/1901 If we're going to target 3.13.2 I'm happy to test that also. Created attachment 523918 [details, diff]
Upstream patch to build 3.14.1 against musl and BSD
Thanks for testing, if possible please test the current stable 3.13.2 if it works out of the box. We'll then kindly ask to re-keyword/re-stabilize it along with ivykis. Thank you. All is well with =syslog-ng-3.13.2 on above mentioned combinations. As expected, it does _not_ require the sgtty.h patch, and works as-is from the tree on all. (In reply to David Flogeras from comment #6) > All is well with =syslog-ng-3.13.2 on above mentioned combinations. As > expected, it does _not_ require the sgtty.h patch, and works as-is from the > tree on all. Thank you very much for testing this out. What about the other architectures that got their keywords dropped outright with no apparent consulting with them? KEYWORDS="alpha amd64 arm arm64 hppa ia64 ~mips ppc ppc64 ~s390 ~sh sparc x86 ~x86-fbsd" All these should get a re-keywording bug, and the previous version mustn't have been dropped before they have the newer versions stable. Please restore the previous version via a partial revert of the removal and handle this properly. An automated check of this bug failed - the following atom is unknown: dev-libs/ivykis Please verify the atom list. I understand your point Mart, however bear in mind that for more than a year, nobody cared about syslog-ng at all. The bump was done 4 months ago with only amd64 and x86 and nobody argued that we should also add their arch. Now we know that we have syslog-ng users on arm/arm64, but maybe those other exotic arches got there years ago and nobody really cares for them anymore. If anyone wishes support I'm all for adding the other arches, but so far this was the only one. My 0.02 as a dumb user: I typically don't notice if a new package gets added to ~arch, because I run stable. If portage warned me that a new ~arch version of an installed package was added, but dropped my arch I probably would; but it doesn't. Also, I typically don't notice if a package stays on the same revision for a year (or more) because it's being neglected, or because it is just a mature package and has no need of an upgrade. I'm not trying to pick a fight, I'm just saying from my perspective (and probably many users), we just wait for packages to stable without putting a whole lot of thought into it. All good, we're fixing it now :) An automated check of this bug failed - repoman reported dependency errors (210 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: RDEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: RDEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
An automated check of this bug failed - repoman reported dependency errors (102 lines truncated):
> dependency.bad dev-libs/mongo-c-driver/mongo-c-driver-1.8.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['dev-db/mongodb']
> dependency.bad dev-libs/mongo-c-driver/mongo-c-driver-1.9.3.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['dev-db/mongodb']
> dependency.badindev dev-libs/mongo-c-driver/mongo-c-driver-1.8.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0/armv4) ['dev-db/mongodb']
> dependency.bad dev-libs/mongo-c-driver/mongo-c-driver-1.8.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['dev-db/mongodb']
> dependency.bad dev-libs/mongo-c-driver/mongo-c-driver-1.9.3.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['dev-db/mongodb']
> dependency.badindev dev-libs/mongo-c-driver/mongo-c-driver-1.8.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0/armv4) ['dev-db/mongodb']
Seems like mongodb cannot run on arm/arm64 either, so for keywording mongo-c-driver we need to do the same as for x86: # No tests on x86 because tests require dev-db/mongodb which don't support # x86 anymore (bug #645994) RESTRICT="x86? ( test )" Or we block syslog-ng[mongodb]. Sorry, I should have mentioned that I only tested the default USE scenario. I guess to spit-ball, adding the arm/arm64 to the conditional test logic in mongo-c-driver would be more flexible but also more maintenance. I looked in the portage git history (only back 2.5 years, I didn't bother with CVS), and mongo-c-driver has never had arm/arm64, so masking the flag would probably be reasonable. The only devil's advocate statement would be that if you did this, you may find out that there are users who were manually keywording mongo-c-driver and come out of the woodwork (like I did :) But I guess that's on them if they have never asked for it to be officially supported? All right, so let's simply block app-admin/syslog-ng[mongodb]. If anyone wishes to enable mongodb support, we can work on that later on. An automated check of this bug failed - repoman reported dependency errors (210 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: RDEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: RDEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~arm(default/linux/arm/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
(In reply to Tomáš Mózes from comment #11) > I understand your point Mart, however bear in mind that for more than a > year, nobody cared about syslog-ng at all. That's not the responsibility or area of arch teams at all. You can't conclude from no new versions appearing that an arch team doesn't care about it. They work with what they are given by the maintainer. > The bump was done 4 months ago > with only amd64 and x86 and nobody argued that we should also add their > arch. I am talking about existing policies and standard ways of handling this. In fact, this is actually an ebuild quiz question... > Now we know that we have syslog-ng users on arm/arm64, but maybe those > other exotic arches got there years ago and nobody really cares for them > anymore. If anyone wishes support I'm all for adding the other arches, but > so far this was the only one. That's not for you to decide without consulting the arch teams. The way to handle this is to NOT remove the old version when it's their last keyworded or stable version, and then file a keywording (and later stabling) bug that asks if they still want it, and tell them to either keyword/stable the new version or drop the keywords from old version too. syslog-ng is one of the primary loggers used with openrc and it is also prominent in various handbooks, and now you've made it impossible to follow the handbook. Just the first arch for example: https://wiki.gentoo.org/wiki/Handbook:Alpha/Installation/Tools Yes, I know there are other options, but now the handbook is giving an option that doesn't exist due to keywords having been removed against policy and without consulting the relevant arch teams. An automated check of this bug failed - repoman reported dependency errors (117 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['>=dev-libs/mongo-c-driver-1.2.0']
(In reply to Mart Raudsepp from comment #20) > syslog-ng is one of the primary loggers used with openrc and it is also > prominent in various handbooks, and now you've made it impossible to follow > the handbook. Just the first arch for example: > https://wiki.gentoo.org/wiki/Handbook:Alpha/Installation/Tools Then it should probably be maintained by the base system (like app-admin/sysklogd)? Yes, you are right, I forgot it's mentioned in the handbook (although it suggests installing app-admin/sysklogd instead). ~ia64/~sparc keyworded An automated check of this bug failed - repoman reported dependency errors (117 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['>=dev-libs/mongo-c-driver-1.2.0']
~ppc64 keyworded An automated check of this bug failed - repoman reported dependency errors (61 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['>=dev-libs/mongo-c-driver-1.2.0']
~ppc keyworded An automated check of this bug failed - repoman reported dependency errors (61 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: RDEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0/desktop) ['>=dev-libs/mongo-c-driver-1.2.0']
~arm/~arm64 added. An automated check of this bug failed - repoman reported dependency errors (13 lines truncated):
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: DEPEND: hppa(default/linux/hppa/13.0) ['>=dev-libs/ivykis-0.36.1']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.13.2.ebuild: RDEPEND: hppa(default/linux/hppa/13.0) ['>=dev-libs/ivykis-0.36.1']
> dependency.bad app-admin/syslog-ng/syslog-ng-3.14.1.ebuild: DEPEND: ~alpha(default/linux/alpha/13.0) ['>=dev-libs/mongo-c-driver-1.2.0']
We'll continue in a new stable request. added ~alpha |