Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 650454

Summary: media-video/mplayer-1.3.0-r4: automagic dependency on dev-libs/DirectFB
Product: Gentoo Linux Reporter: Alexander Miller <alex.miller>
Component: Current packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 606194, 642506    

Description Alexander Miller 2018-03-14 01:46:42 UTC
The directfb USE flag has been removed from media-video/mplayer-1.3.0-r4, but it has been forgotten to add --disable-directfb to configure's args like -r3 did when the flag was disabled. Here's the relevant hunk from a diff of -r3 and -r4:
@@ -418,7 +417,7 @@
        ################
        # Video Output #
        ################
-       uses="directfb md5sum sdl yuv4mpeg"
+       uses="md5sum sdl yuv4mpeg"
        for i in ${uses}; do
                use ${i} || myconf+=" --disable-${i}"
        done
As a result the package will autodetect directfb if it is installed:
$ grep DirectFB /var/log/portage/media-video:mplayer-1.3.0-r4:20180306-022501.log         
Checking for DirectFB ... yes 
$ readelf -d /usr/bin/mplayer | grep direct
 0x0000000000000001 (NEEDED)             Shared library: [libdirectfb-1.7.so.6]
Comment 1 Pacho Ramos gentoo-dev 2018-04-15 08:15:27 UTC
[master fed6d1d9508c] media-video/mplayer: Really disable directfb (#650454)
 1 file changed, 1 insertion(+)
 rename media-video/mplayer/{mplayer-1.3.0-r4.ebuild => mplayer-1.3.0-r5.ebuild} (99%)