Summary: | app-portage/layman: duplicate path prefix when finding git binary for sync on Gentoo prefix | ||
---|---|---|---|
Product: | Portage Development | Reporter: | Pengcheng Xu <i> |
Component: | Unclassified | Assignee: | Layman Overlay Manager project <layman> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | prefix, radim.janalik |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: | [patch] proposed patch for double EPREFIX in app-portage/layman-2.4.2-r2/layman/config.py |
Description
Pengcheng Xu
2018-03-06 18:02:45 UTC
Did you trigger this bug by `layman -a vapoursynth` or something else? Adding this overlay with layman (`layman -a vapoursynth`) didn't give out any errors (working git, no complains); syncing it with emerge did. I do have the `sync-plugin-portage` USE flag enabled on layman. hmmm, could this be a layman problem instead? Portage sources seem fine on first check. This is a layman problem. resolve_command already seems to get a double-prefixed command. Created attachment 576814 [details, diff]
[patch] proposed patch for double EPREFIX in app-portage/layman-2.4.2-r2/layman/config.py
The problem is how git_command is set in layman/config.py
self.root is concatenated with EPREFIX, but it already contains EPREFIX at this point, so as a result, EPREFIX is twice in the path.
This patch in etc/portage/patches/app-portage/layman-2.4.2-r2/ removes self.root from path.
It seems to me that there is the same problem with other paths. This patch hopefully fixes those too, but I tested only git.
As I am new to Gentoo, I am not sure this is the best way of fixing this bug. Maybe EPREFIX should be removed instead of self.root? Or EPREFIX should not be part of self.root at this point? I don't know.
Hi, does this bug still hold? I don't seem to reproduce it. I don't understand why this path works, it can only be when the root argument/self.root thing actually is eroot. In that case eroot + eprefix indeed is double. @layman: please evaluate the patch, and close this bug based on your observations The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=805fe7c0495e1bf3a34d518041e466258944b82b commit 805fe7c0495e1bf3a34d518041e466258944b82b Author: Jakov Smolić <jsmolic@gentoo.org> AuthorDate: 2023-06-22 13:15:09 +0000 Commit: Jakov Smolić <jsmolic@gentoo.org> CommitDate: 2023-06-22 13:15:09 +0000 app-portage/layman: treeclean Closes: https://bugs.gentoo.org/761199 Closes: https://bugs.gentoo.org/609720 Closes: https://bugs.gentoo.org/627930 Closes: https://bugs.gentoo.org/700742 Closes: https://bugs.gentoo.org/649766 Closes: https://bugs.gentoo.org/681144 Closes: https://bugs.gentoo.org/648374 Closes: https://bugs.gentoo.org/545568 Closes: https://bugs.gentoo.org/581890 Closes: https://bugs.gentoo.org/539336 Closes: https://bugs.gentoo.org/590132 Closes: https://bugs.gentoo.org/574190 Closes: https://bugs.gentoo.org/578992 Closes: https://bugs.gentoo.org/540012 Closes: https://bugs.gentoo.org/412883 Closes: https://bugs.gentoo.org/443880 Closes: https://bugs.gentoo.org/480884 Closes: https://bugs.gentoo.org/567386 Closes: https://bugs.gentoo.org/454604 Closes: https://bugs.gentoo.org/567384 Signed-off-by: Jakov Smolić <jsmolic@gentoo.org> app-portage/layman/Manifest | 1 - app-portage/layman/layman-2.4.3.ebuild | 100 --------------------------------- app-portage/layman/layman-9999.ebuild | 100 --------------------------------- app-portage/layman/metadata.xml | 24 -------- profiles/package.mask | 5 -- 5 files changed, 230 deletions(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=abfaed0b3460e638410c0fd74783f8d292d63afc commit abfaed0b3460e638410c0fd74783f8d292d63afc Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2023-09-08 00:41:10 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2023-09-08 00:42:07 +0000 app-portage/layman: treeclan Closes: https://bugs.gentoo.org/761199 Closes: https://bugs.gentoo.org/609720 Closes: https://bugs.gentoo.org/627930 Closes: https://bugs.gentoo.org/700742 Closes: https://bugs.gentoo.org/649766 Closes: https://bugs.gentoo.org/681144 Closes: https://bugs.gentoo.org/648374 Closes: https://bugs.gentoo.org/545568 Closes: https://bugs.gentoo.org/581890 Closes: https://bugs.gentoo.org/539336 Closes: https://bugs.gentoo.org/590132 Closes: https://bugs.gentoo.org/574190 Closes: https://bugs.gentoo.org/578992 Closes: https://bugs.gentoo.org/540012 Closes: https://bugs.gentoo.org/412883 Closes: https://bugs.gentoo.org/443880 Closes: https://bugs.gentoo.org/480884 Closes: https://bugs.gentoo.org/567386 Closes: https://bugs.gentoo.org/454604 Closes: https://bugs.gentoo.org/567384 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> app-portage/layman/Manifest | 1 - app-portage/layman/layman-2.4.3.ebuild | 100 --------------------------------- app-portage/layman/layman-9999.ebuild | 100 --------------------------------- app-portage/layman/metadata.xml | 24 -------- profiles/package.mask | 5 -- 5 files changed, 230 deletions(-) |