| Summary: | app-crypt/gnupg-2.2.5: does not find libusb on prefix with USE=usb | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Guilherme Amadio <amadio> |
| Component: | Current packages | Assignee: | Gentoo Prefix <prefix> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | k_f |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | gnupg-2.2.5.log | ||
|
Description
Guilherme Amadio
2018-03-05 07:29:31 UTC
The dependency is there, and I have libusb installed, but it is not found. $ equery l -p libusb * Searching for libusb ... [-P-] [ ] dev-libs/libusb-1.0.19-r1:1 [-P-] [ ] dev-libs/libusb-1.0.20:1 [IP-] [ ] dev-libs/libusb-1.0.21:1 I also see hard-coded /usr/include in the ebuild, which needs fixing. The problem is not the ebuild, but configure.ac which hardcodes the search path for libusb to "" "/usr/include/libusb-1.0" "/usr/local/include/libusb-1.0" "/usr/pkg/include/libusb-1.0" and then tries to compile a program which includes <libusb.h>.
So what we /could/ do, is (perhaps only for prefix?) add -I${EPREFIX}/usr/include/libusb-1.0 to CPPFLAGS using append-cppflags, which will then make it look at the Prefix installation first.
@k_f: what do you think?
(In reply to Fabian Groffen from comment #2) > > So what we /could/ do, is (perhaps only for prefix?) add > -I${EPREFIX}/usr/include/libusb-1.0 to CPPFLAGS using append-cppflags, which > will then make it look at the Prefix installation first. > > @k_f: what do you think? I'm fine with using append-cppflags in prefix-specific context, as that is clearly a downstream thing we don't need to do any upstream hacking with regards to configure.ac. Will you propose a patch for review? I was thinking about something like this:
diff --git a/app-crypt/gnupg/gnupg-2.2.5.ebuild b/app-crypt/gnupg/gnupg-2.2.5.ebuild
index 172d9ac8f2c..6171a21f0b0 100644
--- a/app-crypt/gnupg/gnupg-2.2.5.ebuild
+++ b/app-crypt/gnupg/gnupg-2.2.5.ebuild
@@ -3,7 +3,7 @@
EAPI="6"
-inherit systemd toolchain-funcs
+inherit flag-o-matic systemd toolchain-funcs
MY_P="${P/_/-}"
@@ -65,6 +65,10 @@ src_configure() {
--enable-scdaemon
$(use_enable usb ccid-driver)
)
+ if use prefix && use usb ; then
+ # bug #649598
+ append-cppflags -I${EPREFIX}/usr/include/libusb-1.0
+ fi
else
myconf+=( --disable-scdaemon )
fi
@amadio, do you have means to quickly test if this works for you?
(In reply to Fabian Groffen from comment #4) > @amadio, do you have means to quickly test if this works for you? has this been tested? Oops, sorry, I missed the previous message. I will test today (on macOS 10.13) and report back. The patch above works, and gnupg-2.2.6 is also affected by this problem. (In reply to Guilherme Amadio from comment #7) > The patch above works, and gnupg-2.2.6 is also affected by this problem. @k_f: tested and works, will you commit the change? The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ec11c72ad79142c7b70862ffc87f8e65c9c40e0 commit 9ec11c72ad79142c7b70862ffc87f8e65c9c40e0 Author: Guilherme Amadio <amadio@gentoo.org> AuthorDate: 2018-08-23 07:36:42 +0000 Commit: Guilherme Amadio <amadio@gentoo.org> CommitDate: 2018-08-23 07:36:51 +0000 app-crypt/gnupg: fix bug #649598, USE=usb on prefix Closes: https://bugs.gentoo.org/649598 Suggested-by: Fabian Groffen <grobian@gentoo.org> Package-Manager: Portage-2.3.47, Repoman-2.3.10 app-crypt/gnupg/gnupg-2.2.9.ebuild | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) |