Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 648548

Summary: x11-libs/libxshmfence-1.2: build fails on FreeBSD
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Gentoo X packagers <x11>
Status: RESOLVED FIXED    
Severity: normal    
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: build.log
0001-Fix-missing-limits.h-include-for-HAVE_UMTX-branch-of.patch

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-02-22 18:22:06 UTC
Created attachment 520642 [details]
build.log

/var/tmp/portage/x11-libs/libxshmfence-1.2/work/libxshmfence-1.2/src/xshmfence_futex.h: In function ‘futex_wake’:
/var/tmp/portage/x11-libs/libxshmfence-1.2/work/libxshmfence-1.2/src/xshmfence_futex.h:40:39: error: ‘INT_MAX’ undeclared (first use in this function)
  return sys_futex(addr, UMTX_OP_WAKE, INT_MAX);
                                       ^~~~~~~

Apparently the HAVE_UMTX branch of the code does not #include <limits.h> for INT_MAX. Adding this '#include' fixes the build.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-02-22 18:25:07 UTC
Created attachment 520644 [details, diff]
0001-Fix-missing-limits.h-include-for-HAVE_UMTX-branch-of.patch

And here's proper upstreamable patch.
Comment 2 Matt Turner gentoo-dev 2018-02-22 22:09:32 UTC
Patch is now upstream. I'll make a tarball release and push it into Gentoo.
Comment 3 Matt Turner gentoo-dev 2018-02-26 17:36:30 UTC
I typo'd "Closes", so...

commit f7f1e8494fcc836894d4f1405f912f2890a9b5bb (HEAD -> master, origin/master, origin/HEAD)
Author: Matt Turner <mattst88@gentoo.org>
Date:   Mon Feb 26 09:30:03 2018 -0800

    x11-libs/libxshmfence: Version bump to 1.3
    
    Clsoes: https://bugs.gentoo.org/648548
    Package-Manager: Portage-2.3.19, Repoman-2.3.6