Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 648476

Summary: media-sound/teamspeak-server-bin-3.1.1 version bump
Product: Gentoo Linux Reporter: Conrad Kostecki <conikost>
Component: Current packagesAssignee: Conrad Kostecki <conikost>
Status: RESOLVED FIXED    
Severity: normal CC: proxy-maint
Priority: Normal Keywords: EBUILD
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/7307
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 650800    
Bug Blocks:    
Attachments: teamspeak-server-bin-3.1.0.ebuild
LICENSE up to 3.0.13.x
License starting with 3.1.0
LICENSE up to 3.0.13.x
LICENSE starting from 3.0.13.x
teamspeak-server-bin-3.1.1.ebuild

Description Conrad Kostecki gentoo-dev 2018-02-22 09:46:45 UTC
TeamSpeak-Server has a new release: 3.1.0.

Mainly, there are 2 important changes. There is a new license and you have to accept the license, in order to be able to use the server.

I would like to have an opinion, how this could be handled by the ebuild.

a) The current license under /usr/portage/license/teamspeak3 is outdated, even for the current ebuild! So it should be changed. And starting with 3.1.0, there is a new license.

So, what would I do?
Update /usr/portage/license/teamspeak3 to newest license, create an /usr/portage/license/teamspeak3_pre310 for the older 3.0.13.x release and update those ebuilds with that license?

b) Gentoo uses LICENSE="" in the eBuilds, so an user has to the ACCEPT_LICENSE="teamspeak3" in order to be able to install the teamspeak-server. At least, thats how I do understand https://www.gentoo.org/glep/glep-0023.html. Would it be in that case okay, if I just create during installation the ".ts3server_license_accepted" file, as the user has already set ACCEPT_LICENSE="teamspeak3"?

Thanks!
Conrad

=== Server Release 3.1.0  14 february 2018
 ! Before you run the teamspeak 3 server it is required that you agree to our license. This license
   can be found in the file "license.txt" or "LICENSE" (depending on your platform), which is
   located in the same location as the ts3server binary (the main folder). If, after reading it,
   you agree to the license, this can be indicated in one of three ways:
   1: Create a file called ".ts3server_license_accepted" in the current working directory. The
      contents of this file are irrelevant and can be empty. For example on linux do:
      touch .ts3server_license_accepted
   2: Start the ts3server with the commandline parameter "license_accepted" set to 1. For example:
      ts3server license_accepted=1
   3: Set the OS environment variable TS3SERVER_LICENSE to "accept". For example on Windows:
      set TS3SERVER_LICENSE=accept
 ! New accounting subsystem. Please read accounting.txt in the docs folder.
 ! Windows xp and vista support has been dropped.
 - Fixed a bug where a channel could be created with a password without the needed permission.
 - fixed some performance issues when copying a server group
 * Accounting server Documentation updated
 + New property 'virtualserver_nickname' allowing to add the server nickname
   into the server settings. Changes to the new property are only possible by
   users with the new 'virtualserver_nickname' permission.
 + New parameter 'wait_until_ready' in ts3db_mariadb.ini that specifies in
   seconds how long the ts3server should wait for the database to become
   available.
 * Released under new license. See accompanying license file.
Comment 1 Conrad Kostecki gentoo-dev 2018-02-22 09:50:18 UTC
Created attachment 520526 [details]
teamspeak-server-bin-3.1.0.ebuild
Comment 2 Conrad Kostecki gentoo-dev 2018-02-22 09:50:40 UTC
Created attachment 520528 [details]
LICENSE up to 3.0.13.x
Comment 3 Conrad Kostecki gentoo-dev 2018-02-22 09:50:59 UTC
Created attachment 520530 [details]
License starting with 3.1.0
Comment 4 Conrad Kostecki gentoo-dev 2018-02-22 09:52:24 UTC
Created attachment 520532 [details]
LICENSE up to 3.0.13.x
Comment 5 Conrad Kostecki gentoo-dev 2018-02-22 09:52:51 UTC
Created attachment 520534 [details]
LICENSE starting from 3.0.13.x
Comment 6 Conrad Kostecki gentoo-dev 2018-02-27 21:13:11 UTC
Created attachment 521344 [details]
teamspeak-server-bin-3.1.1.ebuild
Comment 7 Larry the Git Cow gentoo-dev 2018-04-20 11:53:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e814336642fed280afbf79ad12763b5e7297a49d

commit e814336642fed280afbf79ad12763b5e7297a49d
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-04-20 09:23:29 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-04-20 11:51:32 +0000

    media-sound/teamspeak-server-bin: Drop old versions
    
    Closes: https://bugs.gentoo.org/648476
    Closes: https://github.com/gentoo/gentoo/pull/7307
    Package-Manager: Portage-2.3.30, Repoman-2.3.9

 media-sound/teamspeak-server-bin/Manifest          |  4 -
 media-sound/teamspeak-server-bin/files/server.conf | 14 ----
 .../files/systemd/teamspeak3-r1.service            | 21 ------
 .../files/systemd/teamspeak3.conf                  |  4 -
 .../files/teamspeak-server-bin-init-r1             | 42 -----------
 .../teamspeak-server-bin/files/ts3db_mariadb.ini   |  7 --
 media-sound/teamspeak-server-bin/files/ts3server   | 10 ---
 .../teamspeak-server-bin-3.0.13.6.ebuild           | 87 ----------------------
 .../teamspeak-server-bin-3.0.13.8.ebuild           | 87 ----------------------
 9 files changed, 276 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4071d90b25bd3b193866ab37eec6a7a84f72eba6

commit 4071d90b25bd3b193866ab37eec6a7a84f72eba6
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-04-20 09:21:29 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-04-20 11:51:32 +0000

    media-sound/teamspeak-server-bin: Bump to version 3.1.1
    
    Closes: https://bugs.gentoo.org/648476
    Package-Manager: Portage-2.3.30, Repoman-2.3.9

 media-sound/teamspeak-server-bin/Manifest          |   2 +
 .../teamspeak-server-bin/files/teamspeak.initd     |  45 +++++++
 .../teamspeak-server-bin/files/teamspeak.service   |  16 +++
 .../teamspeak-server-bin/files/teamspeak.tmpfiles  |   4 +
 .../files/ts3db_mariadb.ini.sample                 |   7 ++
 .../teamspeak-server-bin/files/ts3server-bin       |  10 ++
 .../teamspeak-server-bin/files/ts3server.ini       |  23 ++++
 .../files/ts3server_mariadb.ini.sample             |  23 ++++
 media-sound/teamspeak-server-bin/metadata.xml      |   4 +-
 .../teamspeak-server-bin-3.1.1.ebuild              | 133 +++++++++++++++++++++
 10 files changed, 266 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8a19c7b2e5c35f4afc4202287093ee7a6c3dc814

commit 8a19c7b2e5c35f4afc4202287093ee7a6c3dc814
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-04-20 09:09:11 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-04-20 11:51:32 +0000

    profiles/license_groups: add teamspeak3 license to EULA group
    
    Bug: https://bugs.gentoo.org/648476

 profiles/license_groups | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85a03b96ace68056e71e5c8e54dc3b3bd0d3a2d5

commit 85a03b96ace68056e71e5c8e54dc3b3bd0d3a2d5
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2018-04-20 09:07:46 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-04-20 11:51:32 +0000

    licenses/teamspeak3: Update license to current version
    
    Bug: https://bugs.gentoo.org/648476

 licenses/teamspeak3 | 1584 +++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 1141 insertions(+), 443 deletions(-)}